Re: [PATCH v8 2/5] ethdev: common utilities for different SFF specs

Summary must not be a statement. Consider: "add common code for different SFF specs" or something like this. On 5/25/22 06:14, Robin Zhang wrote: This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration "This patch implements" -> "Add support for" Basicaly "This patches" does no

Re: [PATCH v8 2/5] ethdev: common utilities for different SFF specs

On 5/25/22 06:14, Robin Zhang wrote: This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration and some common utilities for SFF-8436/8636 and SFF-8472/8079. Signed-off-by: Robin Zhang [snip] checkpatches.sh complains on the following, please, fix: + /* SFP Temp in 16-bit

[PATCH v8 2/5] ethdev: common utilities for different SFF specs

This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration and some common utilities for SFF-8436/8636 and SFF-8472/8079. Signed-off-by: Robin Zhang --- lib/ethdev/meson.build | 1 + lib/ethdev/sff_common.c | 326 lib/ethdev/sff_common.h | 1