Re: [PATCH v9 1/9] net/tap: do not duplicate fd's

2024-05-02 Thread Stephen Hemminger
On Thu, 2 May 2024 15:51:43 +0100 Ferruh Yigit wrote: > I agree on the fix, only I don't think it belongs to this patch. > > As far as I can see 'rxq_fds' was already initialized to '-1' and > original code was already wrong. > > This patch merges 'rxq_fds' & 'txq_fds' to 'fds', but this patch

Re: [PATCH v9 1/9] net/tap: do not duplicate fd's

2024-05-02 Thread Ferruh Yigit
On 5/2/2024 12:53 AM, Stephen Hemminger wrote: > On Wed, 1 May 2024 12:13:45 +0100 > Ferruh Yigit wrote: > >>> diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c >>> index fa50fe45d7..a78fd50cd4 100644 >>> --- a/drivers/net/tap/tap_flow.c >>> +++ b/drivers/net/tap/tap_flow.c >>>

Re: [PATCH v9 1/9] net/tap: do not duplicate fd's

2024-05-01 Thread Stephen Hemminger
On Wed, 1 May 2024 12:13:45 +0100 Ferruh Yigit wrote: > > diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c > > index fa50fe45d7..a78fd50cd4 100644 > > --- a/drivers/net/tap/tap_flow.c > > +++ b/drivers/net/tap/tap_flow.c > > @@ -1595,8 +1595,9 @@ tap_flow_isolate(struct rte_et

Re: [PATCH v9 1/9] net/tap: do not duplicate fd's

2024-05-01 Thread Ferruh Yigit
On 4/26/2024 4:48 PM, Stephen Hemminger wrote: > The TAP device can use same file descriptopr for both rx and tx queues. > s/descriptopr/descriptor/ > This allows up to 8 queues (versus 4) to be used with secondary process. > > Signed-off-by: Stephen Hemminger <...> > @@ -1141,19 +1132,18 @@

[PATCH v9 1/9] net/tap: do not duplicate fd's

2024-04-26 Thread Stephen Hemminger
The TAP device can use same file descriptopr for both rx and tx queues. This allows up to 8 queues (versus 4) to be used with secondary process. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 197 +++--- drivers/net/tap/rte_eth_tap.h | 3 +- dr