Re: [v2] [RFC] dpaa2: replace system("echo ...") with file i/o

2023-05-04 Thread Mattias Rönnblom
On 2023-05-02 11:54, Sachin Saxena (OSS) wrote: From: Stephen Hemminger Using system() is a bad idea in driver code because it introduces a number of potential security issues. The codeql analysis tool flags this a potential security issue. Instead just use normal stdio to do the same

[v2] [RFC] dpaa2: replace system("echo ...") with file i/o

2023-05-02 Thread Sachin Saxena (OSS)
From: Stephen Hemminger Using system() is a bad idea in driver code because it introduces a number of potential security issues. The codeql analysis tool flags this a potential security issue. Instead just use normal stdio to do the same thing. Compile test only, do not have this hardware

[RFC] dpaa2: replace system("echo ...") with file i/o

2022-06-02 Thread Stephen Hemminger
Using system() is a bad idea in driver code because it introduces a number of potential security issues. The codeql analysis tool flags this a potential security issue. Instead just use normal stdio to do the same thing. Compile test only, do not have this hardware and therefore can not test this