Re: [EXTERNAL] [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Nitin Saxena
Hi Christophe, Please see inline comments Thanks, Nitin On Thu, Oct 17, 2024 at 2:02 PM Christophe Fontaine wrote: > > Hi all, > > What about the following steps: > - update the nodes so they work on the current layer (example: for all L3 > nodes, the current mbuf data offset *must* be pointin

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Nitin Saxena
Hi Robin, See inline comments Thanks, Nitin On Thu, Oct 17, 2024 at 1:20 PM Robin Jarry wrote: > > Hi Nitin, all, > > Nitin Saxena, Oct 17, 2024 at 09:03: > > Hi Robin/David and all, > > > > We realized the feature arc patch series is difficult to understand as > > a new concept. Our objectives

Re: [EXTERNAL] [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Christophe Fontaine
Hi all, What about the following steps: - update the nodes so they work on the current layer (example: for all L3 nodes, the current mbuf data offset *must* be pointing to the IP header) - define a public data structure that would be shared across nodes through priv data, and not dynfields ? Thi

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Robin Jarry
Hi Nitin, all, Nitin Saxena, Oct 17, 2024 at 09:03: Hi Robin/David and all, We realized the feature arc patch series is difficult to understand as a new concept. Our objectives are following with feature arc changes 1. Allow reusability of standard DPDK nodes (defined in lib/nodes/*) wit

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Nitin Saxena
Hi Robin/David and all, We realized the feature arc patch series is difficult to understand as a new concept. Our objectives are following with feature arc changes 1. Allow reusability of standard DPDK nodes (defined in lib/nodes/*) with out-of-tree applications (like grout). Currently out-of-tre

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Nitin Saxena
Hi Robin, Thanks for the review Please see my replies inline Thanks, Nitin On Wed, Oct 16, 2024 at 3:08 PM Robin Jarry wrote: > > Hi folks, > > David Marchand, Oct 16, 2024 at 11:24: > > On Mon, Oct 14, 2024 at 1:12 PM Nitin Saxena wrote: > >> I had pushed non RFC patch series before -rc1 date

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-16 Thread Robin Jarry
Hi folks, David Marchand, Oct 16, 2024 at 11:24: On Mon, Oct 14, 2024 at 1:12 PM Nitin Saxena wrote: I had pushed non RFC patch series before -rc1 date (11th oct). We have an ABI change in this patch series https://patches.dpdk.org/project/dpdk/patch/20241010133111.2764712-3-nsax...@marvell.c

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-16 Thread David Marchand
On Mon, Oct 14, 2024 at 1:12 PM Nitin Saxena wrote: > I had pushed non RFC patch series before -rc1 date (11th oct). > We have an ABI change in this patch series > https://patches.dpdk.org/project/dpdk/patch/20241010133111.2764712-3-nsax...@marvell.com/ > Could you help merge this patch series in

RE: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-14 Thread Nitin Saxena
: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan ; > dev@dpdk.org; Nitin Saxena ; Robin Jarry > ; Christophe Fontaine > Subject: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph > > Hi graph guys, On Sat, Sep 7, 2024 at 9: 31 AM Niti

RE: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-08 Thread Nitin Saxena
ar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan ; > dev@dpdk.org; Nitin Saxena ; Robin Jarry > ; Christophe Fontaine > Subject: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph > > Hi graph guys, On Sat, Sep 7, 2024 at 9: 31 AM Nitin Saxena > wrote: > &

Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-08 Thread David Marchand
Hi graph guys, On Sat, Sep 7, 2024 at 9:31 AM Nitin Saxena wrote: > > Feature arc represents an ordered list of features/protocols at a given > networking layer. It is a high level abstraction to connect various > rte_graph nodes, as feature nodes, and allow packets steering across > these nodes

[RFC PATCH 0/3] add feature arc in rte_graph

2024-09-07 Thread Nitin Saxena
Feature arc represents an ordered list of features/protocols at a given networking layer. It is a high level abstraction to connect various rte_graph nodes, as feature nodes, and allow packets steering across these nodes in a generic manner. Features (or feature nodes) are nodes which handles part