14/10/2021 12:44, Harman Kalra:
> > > But just for understanding, as David suggested that we preserve keep
> > > this flag then why not use it, have rte_malloc and malloc bits and make a
> > decision.
> > > Let driver has the flexibility to choose. Do you see any harm in this?
> >
> > Which flag?
[dpdk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts: implement
> get set APIs
>
> 14/10/2021 12:31, Harman Kalra:
> > From: Thomas Monjalon
> > > 14/10/2021 11:31, Harman Kalra:
> > > > From: Thomas Monjalon
> > > > > 13/10/2021 20:52, Thomas Mon
14/10/2021 12:31, Harman Kalra:
> From: Thomas Monjalon
> > 14/10/2021 11:31, Harman Kalra:
> > > From: Thomas Monjalon
> > > > 13/10/2021 20:52, Thomas Monjalon:
> > > > > 13/10/2021 19:57, Harman Kalra:
> > > > > > From: dev On Behalf Of Harman Kalra
> > > > > > > From: Thomas Monjalon
> > >
[dpdk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts: implement
> get set APIs
>
> 14/10/2021 11:31, Harman Kalra:
> > From: Thomas Monjalon
> > > 13/10/2021 20:52, Thomas Monjalon:
> > > > 13/10/2021 19:57, Harman Kalra:
> > > > > From: dev On Beha
Marchand ; viachesl...@nvidia.com;
> > ma...@nvidia.com
> > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts: implement
> > get set APIs
> >
> > 13/10/2021 20:52, Thomas Monjalon:
> > > 13/10/2021 19:57, Harman Kalra:
> > > > Fro
14/10/2021 11:31, Harman Kalra:
> From: Thomas Monjalon
> > 13/10/2021 20:52, Thomas Monjalon:
> > > 13/10/2021 19:57, Harman Kalra:
> > > > From: dev On Behalf Of Harman Kalra
> > > > > From: Thomas Monjalon
> > > > > > 04/10/2021 11:57, David Marchand:
> > > > > > > On Mon, Oct 4, 2021 at 10:5
On Thu, Oct 14, 2021 at 11:31 AM Harman Kalra wrote:
> If we are making it automatic detection, shall we now even have argument to
> this alloc API?
> I added a flags argument (32 bit) in latest series where each bit of this
> flag can be an allocation capability.
> I used two bits for discrimin
dk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts: implement
> get set APIs
>
> 13/10/2021 20:52, Thomas Monjalon:
> > 13/10/2021 19:57, Harman Kalra:
> > > From: dev On Behalf Of Harman Kalra
> > > > From: Thomas Monjalon
> > > > > 04/10/2021 1
13/10/2021 20:52, Thomas Monjalon:
> 13/10/2021 19:57, Harman Kalra:
> > From: dev On Behalf Of Harman Kalra
> > > From: Thomas Monjalon
> > > > 04/10/2021 11:57, David Marchand:
> > > > > On Mon, Oct 4, 2021 at 10:51 AM Harman Kalra
> > > > wrote:
> > > > > > > > +struct rte_intr_handle *rte_in
13/10/2021 19:57, Harman Kalra:
> From: dev On Behalf Of Harman Kalra
> > From: Thomas Monjalon
> > > 04/10/2021 11:57, David Marchand:
> > > > On Mon, Oct 4, 2021 at 10:51 AM Harman Kalra
> > > wrote:
> > > > > > > +struct rte_intr_handle *rte_intr_handle_instance_alloc(int size,
> > > > > > >
dev@dpdk.org; Ray Kinsella
> > ; Dmitry Kozlyuk ; David
> > Marchand ; viachesl...@nvidia.com;
> > ma...@nvidia.com
> > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts:
> > implement get set APIs
> >
> > 04/10/2021 11:57, Dav
[dpdk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts: implement
> get set APIs
>
> 04/10/2021 11:57, David Marchand:
> > On Mon, Oct 4, 2021 at 10:51 AM Harman Kalra
> wrote:
> > > > > +struct rte_intr_handle *rte_intr_handle_instance_alloc(int size,
> >
04/10/2021 11:57, David Marchand:
> On Mon, Oct 4, 2021 at 10:51 AM Harman Kalra wrote:
> > > > +struct rte_intr_handle *rte_intr_handle_instance_alloc(int size,
> > > > + bool
> > > > +from_hugepage) {
> > > > + struct rte_intr_handle *in
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Monday, October 4, 2021 4:48 PM
> To: Harman Kalra
> Cc: dev@dpdk.org; Ray Kinsella ; David Marchand
>
> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement
> get set APIs
>
> 2021-10-04 10:37 (UTC+), Harm
2021-10-04 10:37 (UTC+), Harman Kalra:
> [...]
> > > +struct rte_intr_handle *rte_intr_handle_instance_index_get(
> > > + struct rte_intr_handle *intr_handle, int
> > index)
> >
> > If rte_intr_handle_instance_alloc() returns a pointer to an array, this
> > function
Hi Dmitry,
Thanks for reviewing the series.
Please find my comments inline.
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Sunday, October 3, 2021 11:35 PM
> To: Harman Kalra
> Cc: dev@dpdk.org; Ray Kinsella
> Subject: [EXT] Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement
On Mon, Oct 4, 2021 at 10:51 AM Harman Kalra wrote:
> > > +struct rte_intr_handle *rte_intr_handle_instance_alloc(int size,
> > > + bool
> > > +from_hugepage) {
> > > + struct rte_intr_handle *intr_handle;
> > > + int i;
> > > +
> >
Hi David,
Thanks for the review.
Please see my comments inline.
> -Original Message-
> From: David Marchand
> Sent: Tuesday, September 28, 2021 9:17 PM
> To: Harman Kalra
> Cc: dev ; Ray Kinsella
> Subject: [EXT] Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement get
> set APIs
>
18 matches
Mail list logo
