On Sat, Aug 01, 2015 at 09:26:34AM +0800, hepeng wrote:
> In *ixgbe_tx_free_bufs*, after recycling some tx entries, one should set
> their mbuf pointers to NULL.
>
> The first path is not correct, the txep->mbuf should be set to NULL no matter
> if it is recycled into mempool
> Signed-off-by: he
Hi, wenzhuo,
Have to check that because I really had the panic when compile my code
with dpdk 2.0.0.
Also I checked the code in the dpdk git repo. It does not check the
reference count, it just only calculate
the begin positions of mbufs that really needs to be recycled.
huo ???
>
> Hi Peng,
>
>> -Original Message-
>> From: HePeng [mailto:xnhp0320 at icloud.com <mailto:xnhp0320 at icloud.com>]
>> Sent: Monday, August 3, 2015 3:09 PM
>> To: Lu, Wenzhuo
>> Cc: dev at dpdk.org <mailto:dev at dpdk.org>
>>
sanity_check*.
>> Thanks.
>>
>>
>>> ? 2015?8?310:46?Lu, Wenzhuo ?
>> ??
>>>
>>> Hi Peng,
>>>
>>>> -Original Message-----
>>>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of hepeng
&
Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling
> ixgbe_tx_free_bufs
>
> Hi, wenzhuo,
> Have to check that because I really had the panic when compile my code
> with dpdk 2.0.0.
>
> Also I checked the code
Hi Peng,
There're 2 versions of ixgbe_tx_queue_release_mbufs. One in ixgbe_rxtx.c, the
other is in ixgbe_rxtx_vec.c.
What you shown is the one in ixgbe_rxtx.c. You can find the one in
ixgbe_rxtx_vec.c already has the sanity check for reference count.
Thanks.
Hi Peng,
> -Original Message-
> From: HePeng [mailto:xnhp0320 at icloud.com]
> Sent: Monday, August 3, 2015 3:09 PM
> To: Lu, Wenzhuo
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling
> ixgbe_tx_free_bufs
>
&
Hi Peng,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of hepeng
> Sent: Saturday, August 1, 2015 9:27 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] [new]ixgbe:set txep.mbuf to NULL when calling
> ixgbe_tx_free_bufs
>
>
In *ixgbe_tx_free_bufs*, after recycling some tx entries, one should set their
mbuf pointers to NULL.
The first path is not correct, the txep->mbuf should be set to NULL no matter
if it is recycled into mempool
Signed-off-by: hepeng
---
drivers/net/ixgbe/ixgbe_rxtx_vec.c | 13 -
1
9 matches
Mail list logo
