llbacks? You could then merge the setup_link code into
>> something like dev_rxtx_start() [ open to suggestions ].
>>
>> Regards,
>> -Venky
>>
>> -Original Message-
>> From: jigsaw [mailto:jigsaw at gmail.com]
>> Sent: Wednesday, September 25
t() [ open to suggestions ].
>
> Regards,
> -Venky
>
> -Original Message-
> From: jigsaw [mailto:jigsaw at gmail.com]
> Sent: Wednesday, September 25, 2013 7:39 AM
> To: Venkatesan, Venky
> Cc: Ivan Boule; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Add suppo
Hi Thomas,
The patch can be made without modifying ixgbe/ at all, I will make
another attempt. Please see the proposal in my previous email.
The question is how to keep the lpbk_mode field in struct rte_eth_conf
future-proof. Or if this is overkill to think about possible future
loopback support a
om: dev [mailto:dev-bounces at dpdk.org] On Behalf Of jigsaw
> Sent: Wednesday, September 25, 2013 6:56 AM
> To: Ivan Boule
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Add support for 82599 Tx->Rx loopback
> operation.
>
> Hi Ivan,
>
> Appreciations for your com
That should work perfectly ... :)
Regards,
-Venky
-Original Message-
From: jigsaw [mailto:jig...@gmail.com]
Sent: Wednesday, September 25, 2013 10:00 AM
To: Venkatesan, Venky
Cc: Ivan Boule; dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Add support for 82599 Tx->Rx loopback operat
Hi Qinglai,
I understand your point.
In fact, because loopback modes are only intended to be used in
debug situations by developers that [are supposed to] know what they
do, it is much simpler to use your approach.
Please, can you add into the file librte_ether/rte_ethdev.h
Hi Ivan,
Appreciations for your comments.
I have one question regarding the new field, lpbk_mode, in struct rte_eth_conf.
I was thinking how to define the values for this field, then I had a dilemma.
82599 has only two mode of loopback, either Tx->Rx or Rx->Tx.
But other controller may have diff
25/09/2013 16:12, Venkatesan, Venky :
> I for one would prefer that the changes not really modify any files in the
> librte_pmd_ixgbe/ixgbe directory. Those files are derived directly from
> the BSD driver baseline, and any changes will make future merges of newer
> code more challenging. The chang
,
> -Venky
>
>
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of jigsaw
> Sent: Wednesday, September 25, 2013 6:56 AM
> To: Ivan Boule
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Add support for 82599 Tx->Rx loopback
Hi Qinglai Xiao,
See my remarks inline prefixed with IB>
Best regards,
Ivan
On 09/23/2013 09:16 PM, Qinglai Xiao wrote:
> Signed-off-by: Qinglai Xiao
> ---
> lib/librte_ether/rte_ethdev.h|1 +
> lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c | 122
> +++
files in the librte_pmd_ixgbe
directory (and ethdev).
Regards,
-Venky
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of jigsaw
Sent: Wednesday, September 25, 2013 6:56 AM
To: Ivan Boule
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Add support for 82599 Tx->
Signed-off-by: Qinglai Xiao
---
lib/librte_ether/rte_ethdev.h|1 +
lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c | 122 +-
lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h |7 ++
lib/librte_pmd_ixgbe/ixgbe_ethdev.c |8 ++
lib/librte_pmd_ixgbe/ixgbe_rxt
12 matches
Mail list logo
