Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-23 Thread David Marchand
On Tue, Jul 16, 2019 at 5:29 PM Ferruh Yigit wrote: > > On 7/16/2019 4:00 PM, Andrew Rybchenko wrote: > > On 7/16/19 5:28 PM, Bruce Richardson wrote: > >> On Tue, Jul 16, 2019 at 03:23:03PM +0100, Ferruh Yigit wrote: > >>> On 7/16/2019 1:23 PM, Andrew Rybchenko wrote: > On 7/15/19 5:53 PM, Fe

Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-16 Thread Ferruh Yigit
On 7/16/2019 4:00 PM, Andrew Rybchenko wrote: > On 7/16/19 5:28 PM, Bruce Richardson wrote: >> On Tue, Jul 16, 2019 at 03:23:03PM +0100, Ferruh Yigit wrote: >>> On 7/16/2019 1:23 PM, Andrew Rybchenko wrote: On 7/15/19 5:53 PM, Ferruh Yigit wrote: > On 7/12/2019 9:32 AM, A.McLoughlin wrote:

Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-16 Thread Andrew Rybchenko
On 7/16/19 5:28 PM, Bruce Richardson wrote: On Tue, Jul 16, 2019 at 03:23:03PM +0100, Ferruh Yigit wrote: On 7/16/2019 1:23 PM, Andrew Rybchenko wrote: On 7/15/19 5:53 PM, Ferruh Yigit wrote: On 7/12/2019 9:32 AM, A.McLoughlin wrote: The 'Accumulated forward statistics for all ports' incorrec

Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-16 Thread Bruce Richardson
On Tue, Jul 16, 2019 at 03:23:03PM +0100, Ferruh Yigit wrote: > On 7/16/2019 1:23 PM, Andrew Rybchenko wrote: > > On 7/15/19 5:53 PM, Ferruh Yigit wrote: > >> On 7/12/2019 9:32 AM, A.McLoughlin wrote: > >>> The 'Accumulated forward statistics for all ports' incorrectly displayed > >>> double the ac

Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-16 Thread Ferruh Yigit
On 7/16/2019 1:23 PM, Andrew Rybchenko wrote: > On 7/15/19 5:53 PM, Ferruh Yigit wrote: >> On 7/12/2019 9:32 AM, A.McLoughlin wrote: >>> The 'Accumulated forward statistics for all ports' incorrectly displayed >>> double the actual value for 'total_tx_dropped'. This was because 2 >>> lines in the s

Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-16 Thread Andrew Rybchenko
On 7/15/19 5:53 PM, Ferruh Yigit wrote: On 7/12/2019 9:32 AM, A.McLoughlin wrote: The 'Accumulated forward statistics for all ports' incorrectly displayed double the actual value for 'total_tx_dropped'. This was because 2 lines in the same function both incremented total_tx_dropped every time a

Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-15 Thread Ferruh Yigit
On 7/12/2019 9:32 AM, A.McLoughlin wrote: > The 'Accumulated forward statistics for all ports' incorrectly displayed > double the actual value for 'total_tx_dropped'. This was because 2 > lines in the same function both incremented total_tx_dropped every time > a packet was dropped. I removed one

Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-12 Thread Iremonger, Bernard
Hi Aideen, > -Original Message- > From: Mcloughlin, Aideen > Sent: Friday, July 12, 2019 9:32 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Mcloughlin, Aideen ; > david.march...@redhat.com; sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix doubling of

[dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'

2019-07-12 Thread A.McLoughlin
The 'Accumulated forward statistics for all ports' incorrectly displayed double the actual value for 'total_tx_dropped'. This was because 2 lines in the same function both incremented total_tx_dropped every time a packet was dropped. I removed one of these lines to fix this issue. Fixes: 53324971