Re: [dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range

2020-02-19 Thread Ferruh Yigit
On 2/19/2020 2:02 PM, Iremonger, Bernard wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, February 19, 2020 12:40 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> ; Lipiec, Herakliusz >> ; Govindharajan, Hariprasad >> ; Burakov, Anatoly >> >> Cc

Re: [dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range

2020-02-19 Thread Iremonger, Bernard
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, February 19, 2020 12:40 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Lipiec, Herakliusz > ; Govindharajan, Hariprasad > ; Burakov, Anatoly > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH] app/testpmd

Re: [dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range

2020-02-19 Thread Lipiec, Herakliusz
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, February 19, 2020 12:40 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Lipiec, Herakliusz > ; Govindharajan, Hariprasad > ; Burakov, Anatoly > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH] app/testpmd: g

[dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range

2020-02-19 Thread Ferruh Yigit
Coverity complains about out of bound access, which is a false positive. The return value of the 'parse_port_list()' can't be bigger than 'maxsize' because of the logic in the function. ('value >= (int)maxsize' check and 'marked[]' usage.) But this is not explicitly clear, causing coverity warnin