Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-23 Thread Iremonger, Bernard
Hi Ferruh, > >> Duplication is bad, it is bad to have two different ways to do same thing. > >> I am not sure if Vivek is aware of duplicated functions but > >> explicitly prefers to update old versions. > >> I suggest lets stop improving these ones and get rid of them asap. > > > > Testpmd is w

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 6:03 PM, Iremonger, Bernard wrote: > Hi Ferruh, > > > >>>>>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip >>>>>> offload >>>>>> >>>>>> On 7/17/2019 8:45 AM, viveksha...@marvell.

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Iremonger, Bernard
Hi Ferruh, > >>>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip > >>>> offload > >>>> > >>>> On 7/17/2019 8:45 AM, viveksha...@marvell.com wrote: > >>>>> From: Vivek Sharma > >>>>&

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Ferruh Yigit
f Ferruh Yigit >>>> Sent: Friday, July 19, 2019 5:53 PM >>>> To: viveksha...@marvell.com; dev@dpdk.org >>>> Cc: intoviveksha...@gmail.com >>>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip >>>> offload >>>> >

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, July 22, 2019 3:27 PM > To: Iremonger, Bernard ; > viveksha...@marvell.com; dev@dpdk.org > Cc: intoviveksha...@gmail.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload &

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Ferruh Yigit
viveksha...@gmail.com >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload >> >> On 7/17/2019 8:45 AM, viveksha...@marvell.com wrote: >>> From: Vivek Sharma >>> >>> Support QinQ strip RX offload configuration through testpmd command &g

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, July 19, 2019 5:53 PM > To: viveksha...@marvell.com; dev@dpdk.org > Cc: intoviveksha...@gmail.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-19 Thread Ferruh Yigit
On 7/17/2019 8:45 AM, viveksha...@marvell.com wrote: > From: Vivek Sharma > > Support QinQ strip RX offload configuration through > testpmd command line and boot time arguments. For the testpmd command part, unfortunately there are two set of commands for same purpose, the new ones are (lets bot

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-17 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > viveksha...@marvell.com > Sent: Wednesday, July 17, 2019 8:45 AM > To: dev@dpdk.org > Cc: intoviveksha...@gmail.com; Vivek Sharma > > Subject: [dpdk-dev] [PATCH] app/testpmd: support QinQ

[dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-17 Thread viveksharma
From: Vivek Sharma Support QinQ strip RX offload configuration through testpmd command line and boot time arguments. Signed-off-by: Vivek Sharma --- app/test-pmd/cmdline.c | 24 ++- app/test-pmd/config.c | 36 ++