Hi,
Thanks for your review. I got it!
Yanglong Wu
-Original Message-
From: Shahaf Shuler [mailto:shah...@mellanox.com]
Sent: Sunday, February 4, 2018 2:27 PM
To: Wu, Yanglong ; dev@dpdk.org
Cc: Lu, Wenzhuo
Subject: RE: [PATCH] app/testpmd:vlan filter fail
Hi Wu,
Indeed there is an issu
Hi Wu,
Indeed there is an issue here, but this is not the right fix.
Friday, February 2, 2018 7:10 AM, Yanglong Wu:
> Subject: [PATCH] app/testpmd:vlan filter fail
>
> Removing out port_conf.rxmode.hw_vlan_filter = 1 will let it equal to 0 and
> port_conf.rxmode.offloads is assigned as 0 again i
Removing out port_conf.rxmode.hw_vlan_filter = 1
will let it equal to 0 and port_conf.rxmode.offloads
is assigned as 0 again if hw_vlan_filter = 1. So it
will always lead to fail for vlan filter setting
Fix:0074d02fc(convert to new Rx offloads API)
Signed-off-by: Yanglong Wu
---
app/test-pmd/tes
Hi,
This patch is wrong, but there is bug absolutely.
The problem can be stated as following：
in your patch(0074d02fc),
@@ -2224,7 +2221,7 @@ init_port_dcb_config(portid_t pid,
retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en);
if (retval < 0)
return
Thursday, February 1, 2018 3:27 AM, Yanglong Wu:
> And-operartion with a constant will
> always lead to fail for vlan filter.
It will work after dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_VLAN_FILTER , right?
I don't understand what this patch tries to fix.
>
> fix:0074d02fc(conve
01/02/2018 02:26, Yanglong Wu:
> And-operartion with a constant will
> always lead to fail for vlan filter.
>
> fix:0074d02fc(convert to new Rx offloads API)
> Signed-off-by: Yanglong Wu
[...]
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -2288,7 +2288,7 @@ rte_
And-operartion with a constant will
always lead to fail for vlan filter.
fix:0074d02fc(convert to new Rx offloads API)
Signed-off-by: Yanglong Wu
---
lib/librte_ether/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether
7 matches
Mail list logo
