Hi,
Here is a suggestion for the title:
net: fix uneeded replacement of 0 by for TCP checksum
The commit log looks good to me, but you can add:
Fixes: 6006818cfb26 ("net: new checksum functions")
Cc: sta...@dpdk.org
On Wed, May 27, 2020 at 05:36:59PM +0200, Morten Brørup wrote:
> >
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, May 27, 2020 5:03 PM
>
> On Wed, 27 May 2020 22:41:27 +0800
> guohongzhi wrote:
>
> > + /* For Udp, if the computed checksum is zero,
> > +* it is transmitted as all ones.RFC768
> > +*/
> > +
On Wed, 27 May 2020 22:41:27 +0800
guohongzhi wrote:
> + /* For Udp, if the computed checksum is zero,
> + * it is transmitted as all ones.RFC768
> + */
> + if (cksum == 0 && ipv4_hdr->next_proto_id == IPPROTO_UDP)
> cksum = 0x;
>
The comment should be refo
From: Hongzhi Guo
RFC 768 for UDP specifies:
If the computed checksum is zero, it is transmitted as all ones.
An all zero transmitted checksum value means that the transmitter
generated no checksum.
RFC 793 for TCP has no such special treatment for the checksum of zero.
Signed-off-by: Hon
RFC 768 for UDP specifies:
If the computed checksum is zero, it is transmitted as all ones.
An all zero transmitted checksum value means that the transmitter
generated no checksum.
RFC 793 for TCP has no such special treatment for the checksum of zero.
Signed-off-by: guohongzhi
---
lib/li
5 matches
Mail list logo
