Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson

2018-09-17 Thread Bruce Richardson
On Sun, Sep 16, 2018 at 11:14:10AM +0200, Thomas Monjalon wrote: > 30/08/2018 19:31, Luca Boccassi: > > On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote: > > > For meson builds, the define to enable the symbol version > > > macros in rte_compat.h was missing. This led to symbols being > >

Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson

2018-09-16 Thread Thomas Monjalon
30/08/2018 19:31, Luca Boccassi: > On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote: > > For meson builds, the define to enable the symbol version > > macros in rte_compat.h was missing. This led to symbols being > > omitted from shared objects. For example, checking rte_distributor.so > >

Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson

2018-08-30 Thread Luca Boccassi
On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote: > For meson builds, the define to enable the symbol version > macros in rte_compat.h was missing. This led to symbols being > omitted from shared objects. For example, checking rte_distributor.so > with objdump and comparing make and meson

[dpdk-dev] [PATCH] compat: fix symbol version support with meson

2018-08-30 Thread Bruce Richardson
For meson builds, the define to enable the symbol version macros in rte_compat.h was missing. This led to symbols being omitted from shared objects. For example, checking rte_distributor.so with objdump and comparing make and meson built versions: $ objdump -T make-build/lib/librte_distributor.so