Re: [dpdk-dev] [PATCH] compress/isal: fix use after free

2019-06-19 Thread Akhil Goyal
> > > > > > The release function was using qp->stream after already releasing it and > > > the > > > null pointer checking was missing. > > > > > > Also since rte_free(NULL) is a no-op, remove unnecessary checks for NULL. > > > > > > Coverity issure: 340860 > > > Fixes: dc49e6aa4879 ("compress/isa

Re: [dpdk-dev] [PATCH] compress/isal: fix use after free

2019-05-27 Thread Trahe, Fiona
> -Original Message- > From: Daly, Lee > Sent: Tuesday, May 21, 2019 4:08 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [PATCH] compress/isal: fix use after free > > Hi Stephen, > Thanks for the patch. > > > -Original Message- > > From: Stephen He

Re: [dpdk-dev] [PATCH] compress/isal: fix use after free

2019-05-21 Thread Daly, Lee
Hi Stephen, Thanks for the patch. > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, May 21, 2019 3:47 PM > To: Daly, Lee > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH] compress/isal: fix use after free > > The release function

[dpdk-dev] [PATCH] compress/isal: fix use after free

2019-05-21 Thread Stephen Hemminger
The release function was using qp->stream after already releasing it and the null pointer checking was missing. Also since rte_free(NULL) is a no-op, remove unnecessary checks for NULL. Coverity issure: 340860 Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality") Signed-off-b