Re: [dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-19 Thread David Marchand
On Tue, Mar 10, 2020 at 10:32 AM Bruce Richardson wrote: > > On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote: > > If contigmem is not able to allocate all of the > > requested buffers, it frees whatever buffers were > > able to be allocated up until that point. > > > > But the pointers

Re: [dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-19 Thread Harris, James R
On 3/19/20, 5:54 AM, "David Marchand" wrote: On Tue, Mar 10, 2020 at 10:32 AM Bruce Richardson wrote: > > On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote: > > If contigmem is not able to allocate all of the > > requested buffers, it frees whatever buffers we

Re: [dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-19 Thread David Marchand
On Tue, Mar 10, 2020 at 10:32 AM Bruce Richardson wrote: > > On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote: > > If contigmem is not able to allocate all of the > > requested buffers, it frees whatever buffers were > > able to be allocated up until that point. > > > > But the pointers

Re: [dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-10 Thread Bruce Richardson
On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote: > If contigmem is not able to allocate all of the > requested buffers, it frees whatever buffers were > able to be allocated up until that point. > > But the pointers are not set to NULL in that case. > After the load fails, the FreeBSD k

[dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-09 Thread Jim Harris
If contigmem is not able to allocate all of the requested buffers, it frees whatever buffers were able to be allocated up until that point. But the pointers are not set to NULL in that case. After the load fails, the FreeBSD kernel will immediately call the contigmem unload handler, which tries to