Re: [dpdk-dev] [PATCH] cryptodev: make xform key pointer constant

2019-03-15 Thread Kusztal, ArkadiuszX
Hi Fan, Only one thing from me (with [AK]) Except for that looks good, I can ack v2. Arek > -Original Message- > From: Zhang, Roy Fan > Sent: Friday, March 1, 2019 2:43 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; > Kusztal, ArkadiuszX ; > jerin.ja...@caviumnetworks.c

[dpdk-dev] [PATCH] cryptodev: make xform key pointer constant

2019-03-01 Thread Fan Zhang
This patch changes the key pointer data types in cipher, auth, and aead xforms from "uint8_t *" to "const uint8_t *" for a more intuitive and safe sessionn creation. Signed-off-by: Fan Zhang --- Although it is a relative big patch, but I believe it is the right thing to do towards a safer and bet