Re: [dpdk-dev] [PATCH] cryptodev: rename experimental private data APIs

2018-07-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, July 10, 2018 7:29 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > jerin.ja...@caviumnetworks.com; Vangati, Narender > ; Akhil Goyal > Subject: RE: [PATCH] cryptodev: rename experimental private data

Re: [dpdk-dev] [PATCH] cryptodev: rename experimental private data APIs

2018-07-09 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Trahe, Fiona > Sent: Friday, July 6, 2018 7:10 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Gujjar, Abhinandan S > Subject: [PATCH] cryptodev: rename experimental private data APIs > > The name private_dat

Re: [dpdk-dev] [PATCH] cryptodev: rename experimental private data APIs

2018-07-09 Thread De Lara Guarch, Pablo
Hi Abhinandan, > -Original Message- > From: Gujjar, Abhinandan S > Sent: Monday, July 9, 2018 8:34 AM > To: Trahe, Fiona ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; Akhil Goyal > Cc: De Lara Guarch, Pablo > Subject: RE: [PATCH] cryptodev: rename experimental private data APIs > >

Re: [dpdk-dev] [PATCH] cryptodev: rename experimental private data APIs

2018-07-09 Thread Gujjar, Abhinandan S
Adding Jerin & Akhil into the loop. Since these APIs are experimental, does the changes require announcement? Regards Abhinandan > -Original Message- > From: Trahe, Fiona > Sent: Friday, July 6, 2018 7:10 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Gujjar, Abhina

[dpdk-dev] [PATCH] cryptodev: rename experimental private data APIs

2018-07-06 Thread Fiona Trahe
The name private_data is confusing in these APIs: rte_cryptodev_sym_session_set_private_data() rte_cryptodev_sym_session_get_private_data() It refers to data added at the end of the session hdr for use by the application. The session already contains sess_private_data[index] which is used to store