Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-10-07 Thread David Marchand
On Wed, Oct 7, 2020 at 12:41 PM Doherty, Declan wrote: > >> @@ -789,33 +781,9 @@ rte_cryptodev_stats_reset(uint8_t dev_id); > >>* the last valid element has it's op field set to > >>* RTE_CRYPTO_OP_TYPE_UNDEFINED. > >>*/ > >> - > >> -void > >> +extern void > > Nit: no need for extern.

Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-10-07 Thread Doherty, Declan
On 06/10/2020 1:32 PM, David Marchand wrote: For the title, I would suggest: "cryptodev: remove v20 ABI compatibility" You did this change using a revert, but still, we can avoid restoring coding style issues, see nits below. On Fri, Aug 14, 2020 at 12:00 PM Adam Dybkowski wrote: This reve

Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-10-06 Thread Dybkowski, AdamX
> -Original Message- > From: David Marchand > Sent: Tuesday, 6 October, 2020 14:32 > To: Dybkowski, AdamX > Cc: dev ; Trahe, Fiona ; Akhil Goyal > ; Kusztal, ArkadiuszX > ; Thomas Monjalon > ; Ray Kinsella > Subject: Re: [dpdk-dev] [PATCH] cryptodev: r

Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-10-06 Thread David Marchand
For the title, I would suggest: "cryptodev: remove v20 ABI compatibility" You did this change using a revert, but still, we can avoid restoring coding style issues, see nits below. On Fri, Aug 14, 2020 at 12:00 PM Adam Dybkowski wrote: > > This reverts commit a0f0de06d457753c94688d551a6e8659b4d

Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-08-25 Thread Kusztal, ArkadiuszX
-Original Message- From: Dybkowski, AdamX Sent: piÄ…tek, 14 sierpnia 2020 12:00 To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com Cc: Dybkowski, AdamX ; Kusztal, ArkadiuszX Subject: [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305 This reverts commit a0f0de06d4577

[dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-08-14 Thread Adam Dybkowski
This reverts commit a0f0de06d457753c94688d551a6e8659b4d4e041 as the rte_cryptodev_info_get function versioning was a temporary solution to maintain ABI compatibility for ChaCha20-Poly1305 and is not needed in 20.11. Fixes: a0f0de06d457 ("cryptodev: fix ABI compatibility for ChaCha20-Poly1305") Si