Re: [dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script issue

2018-10-19 Thread Neil Horman
On Fri, Oct 19, 2018 at 02:09:51PM +0100, Liang, Ma wrote: > Hi Neil, >there are two things here. >1. This issue give me negative report when I run checkpatch. > So, I hope we can disable symbol check before we fix it. > You're welcome to disable the check locally I suppose, but I'

Re: [dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script issue

2018-10-19 Thread Liang, Ma
Hi Neil, there are two things here. 1. This issue give me negative report when I run checkpatch. So, I hope we can disable symbol check before we fix it. 2. How to fix that I still don't understand why we need match section name start with '+'. The section name should

Re: [dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script issue

2018-10-19 Thread Neil Horman
On Fri, Oct 19, 2018 at 12:48:57PM +0200, Thomas Monjalon wrote: > Hi Neil, > > Are you OK with this patch? > > > 04/10/2018 17:18, Liang Ma: > > There is a issue inside check-symbol-changes.sh awk script. > > When the script try to parse the section name from patch, > > The script put char "+"

Re: [dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script issue

2018-10-19 Thread Thomas Monjalon
Hi Neil, Are you OK with this patch? 04/10/2018 17:18, Liang Ma: > There is a issue inside check-symbol-changes.sh awk script. > When the script try to parse the section name from patch, > The script put char "+" into the section name. > > Signed-off-by: Liang Ma > --- > devtools/check-symbo

[dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script issue

2018-10-04 Thread Liang Ma
There is a issue inside check-symbol-changes.sh awk script. When the script try to parse the section name from patch, The script put char "+" into the section name. Signed-off-by: Liang Ma --- devtools/check-symbol-change.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/de