Re: [dpdk-dev] [PATCH] devtools: check wrong svg include in patches

2018-10-31 Thread Arnon Warshavsky
> > and added an extra backslash > > Are you sure we need an extra backslash? > Note that I am using single quotes. > I thought we need only 2 backslashes in this case. > You are right. Its only required with double quotes

Re: [dpdk-dev] [PATCH] devtools: check wrong svg include in patches

2018-10-31 Thread Thomas Monjalon
Hi Arnon, 31/10/2018 16:46, Arnon Warshavsky: > Hi Thomas > > Glad the function gets to be reused :) > Now that it has more than one consumer apparently the function > check_forbidden_additions() cannot be fed by stdin. > I got it working with 3 changes: Thanks for the help > 1. call the awk sc

Re: [dpdk-dev] [PATCH] devtools: check wrong svg include in patches

2018-10-31 Thread Arnon Warshavsky
Hi Thomas Glad the function gets to be reused :) Now that it has more than one consumer apparently the function check_forbidden_additions() cannot be fed by stdin. I got it working with 3 changes: 1. call the awk script with $tmpinput as a parameter instead of stdin. This aligns with Neils change

[dpdk-dev] [PATCH] devtools: check wrong svg include in patches

2018-10-31 Thread Thomas Monjalon
Including svg files with the svg extension is a common mistake: .. figure:: example.svg must be .. figure:: example.* So it will work also when building pdf doc with figures converted to png files. A check is added in checkpatches.sh. Signed-off-by: Thomas Monjalon PS: it seems