Re: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved

2021-11-26 Thread Thomas Monjalon
23/10/2021 12:29, David Marchand: > __reserved is a reserved keyword in Windows system headers. > > Signed-off-by: David Marchand [...] > + # refrain from using __reserved which is a reserved keyword in Windows > + # system headers Reworded as "forbid" Applied, thanks.

Re: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved

2021-11-10 Thread Tyler Retzlaff
On Sat, Oct 23, 2021 at 12:29:00PM +0200, David Marchand wrote: > __reserved is a reserved keyword in Windows system headers. > fwiw it's the c standard that stipulates identifiers starting with __ are reserved for any use. C11/C99 "ANSI-C" 7.1.3 Reserved Identifiers `All identifiers that be

Re: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved

2021-10-28 Thread Walsh, Conor
> From: dev On Behalf Of David Marchand > Sent: Saturday 23 October 2021 11:29 > To: dev@dpdk.org > Cc: dmitry.kozl...@gmail.com; Thomas Monjalon > Subject: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved > > __reserved is a reserved keyword in Windows system

Re: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved

2021-10-27 Thread Bruce Richardson
On Sat, Oct 23, 2021 at 12:29:00PM +0200, David Marchand wrote: > __reserved is a reserved keyword in Windows system headers. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] devtools: forbid additions of __reserved

2021-10-23 Thread David Marchand
__reserved is a reserved keyword in Windows system headers. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index c314d83a29..25f60a4a27 100755 --- a/devtools/checkpatches.