Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check

2021-10-27 Thread Thomas Monjalon
27/10/2021 15:08, Bruce Richardson: > On Tue, Oct 26, 2021 at 02:20:45PM +, Kevin Laatz wrote: > > When checking if the DMA device is active, the result of the operand will > > always be zero since the err_code is truncated to 8 bits which makes > > checking the 31st bit impossible. > > > > Th

Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check

2021-10-27 Thread Walsh, Conor
> From: dev On Behalf Of Kevin Laatz > Sent: Tuesday 26 October 2021 15:21 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Laatz, Kevin > > Subject: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status > check > > When checking if the DMA device is active, the

Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check

2021-10-27 Thread Bruce Richardson
On Tue, Oct 26, 2021 at 02:20:45PM +, Kevin Laatz wrote: > When checking if the DMA device is active, the result of the operand will > always be zero since the err_code is truncated to 8 bits which makes > checking the 31st bit impossible. > > This is fixed by changing the type of err_code to

[dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check

2021-10-26 Thread Kevin Laatz
When checking if the DMA device is active, the result of the operand will always be zero since the err_code is truncated to 8 bits which makes checking the 31st bit impossible. This is fixed by changing the type of err_code to uint32_t so that it is not truncated. Coverity issue: 373657 Fixes: 94