Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-08-10 Thread Thomas Monjalon
06/08/2019 13:24, Thomas Monjalon: > 23/07/2019 16:22, Ferruh Yigit: > > On 7/23/2019 3:07 PM, Andrew Rybchenko wrote: > > > void return value is bad for get API (like rte_eth_dev_info-get()) > > > since caller does not know if the function does its job or not and > > > output value is filled in. >

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-08-06 Thread Thomas Monjalon
23/07/2019 16:22, Ferruh Yigit: > On 7/23/2019 3:07 PM, Andrew Rybchenko wrote: > > void return value is bad for get API (like rte_eth_dev_info-get()) > > since caller does not know if the function does its job or not and > > output value is filled in. > > > > void return value is bad for state ch

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-07-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Tuesday, July 23, 2019 7:38 PM > To: Thomas Monjalon ; Ferruh Yigit > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API > returning void > >

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-07-23 Thread Andrew Rybchenko
On 7/23/19 5:38 PM, Stephen Hemminger wrote: On Tue, 23 Jul 2019 15:07:51 +0100 Andrew Rybchenko wrote: void return value is bad for get API (like rte_eth_dev_info-get()) since caller does not know if the function does its job or not and output value is filled in. void return value is bad for

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-07-23 Thread Stephen Hemminger
On Tue, 23 Jul 2019 15:07:51 +0100 Andrew Rybchenko wrote: > void return value is bad for get API (like rte_eth_dev_info-get()) > since caller does not know if the function does its job or not and > output value is filled in. > > void return value is bad for state changing API (like > rte_eth_pr

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-07-23 Thread Ferruh Yigit
On 7/23/2019 3:07 PM, Andrew Rybchenko wrote: > void return value is bad for get API (like rte_eth_dev_info-get()) > since caller does not know if the function does its job or not and > output value is filled in. > > void return value is bad for state changing API (like > rte_eth_promiscuous_enabl

[dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-07-23 Thread Andrew Rybchenko
void return value is bad for get API (like rte_eth_dev_info-get()) since caller does not know if the function does its job or not and output value is filled in. void return value is bad for state changing API (like rte_eth_promiscuous_enable()) since caller should use get API to understand if stat