Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

On 5/20/2021 5:16 PM, Dmitry Kozlyuk wrote: > 2021-05-20 17:04 (UTC+0100), Ferruh Yigit: >> On 5/20/2021 4:50 PM, Dmitry Kozlyuk wrote: >>> 2021-05-20 16:27 (UTC+0100), Ferruh Yigit: On 5/20/2021 4:06 PM, Dmitry Kozlyuk wrote: > 2021-05-20 15:24 (UTC+0100), Ferruh Yigit: >> On

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

2021-05-20 17:04 (UTC+0100), Ferruh Yigit: > On 5/20/2021 4:50 PM, Dmitry Kozlyuk wrote: > > 2021-05-20 16:27 (UTC+0100), Ferruh Yigit: > >> On 5/20/2021 4:06 PM, Dmitry Kozlyuk wrote: > >>> 2021-05-20 15:24 (UTC+0100), Ferruh Yigit: > On 3/3/2021 10:51 PM, Dmitry Kozlyuk wrote: >

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

On 5/20/2021 4:50 PM, Dmitry Kozlyuk wrote: > 2021-05-20 16:27 (UTC+0100), Ferruh Yigit: >> On 5/20/2021 4:06 PM, Dmitry Kozlyuk wrote: >>> 2021-05-20 15:24 (UTC+0100), Ferruh Yigit: On 3/3/2021 10:51 PM, Dmitry Kozlyuk wrote: >>> [...] > > It is not mandatory to rename `d_addr`,

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

2021-05-20 16:27 (UTC+0100), Ferruh Yigit: > On 5/20/2021 4:06 PM, Dmitry Kozlyuk wrote: > > 2021-05-20 15:24 (UTC+0100), Ferruh Yigit: > >> On 3/3/2021 10:51 PM, Dmitry Kozlyuk wrote: > > [...] > >>> > >>> It is not mandatory to rename `d_addr`, this is for consistency only. > >>> Naming in

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

On 5/20/2021 4:06 PM, Dmitry Kozlyuk wrote: > 2021-05-20 15:24 (UTC+0100), Ferruh Yigit: >> On 3/3/2021 10:51 PM, Dmitry Kozlyuk wrote: > [...] >>> >>> It is not mandatory to rename `d_addr`, this is for consistency only. >>> Naming in `rte_ether_hdr` will also resemble `rte_ipv4/6_hdr`. >>> >>> Wo

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

2021-05-20 15:24 (UTC+0100), Ferruh Yigit: > On 3/3/2021 10:51 PM, Dmitry Kozlyuk wrote: [...] > > > > It is not mandatory to rename `d_addr`, this is for consistency only. > > Naming in `rte_ether_hdr` will also resemble `rte_ipv4/6_hdr`. > > > > Workaround is to define `struct rte_ether_hdr` in

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

On 3/4/2021 7:09 AM, Dmitry Kozlyuk wrote: > 2021-03-03 15:54, Stephen Hemminger: >>> + >>> +* net: ``s_addr`` and ``d_addr`` fields of ``rte_ether_hdr`` structure >>> + will be renamed to ``src_addr`` and ``dst_addr`` respectively in DPDK >>> 20.11 >>> + in order to avoid conflict with Windows

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

On 3/3/2021 10:51 PM, Dmitry Kozlyuk wrote: > It is proposed to rename fields of `struct rte_ether_hdr`, > `s_addr` tp `src_addr` and `d_addr` to `dst_addr`, s/tp/to/ > due to the clash with system macro on Windows. > Until remaining is done in 21.11, a workaround can be used. s/remaining/renami

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

2021-03-03 15:54, Stephen Hemminger: > > + > > +* net: ``s_addr`` and ``d_addr`` fields of ``rte_ether_hdr`` structure > > + will be renamed to ``src_addr`` and ``dst_addr`` respectively in DPDK > > 20.11 > > + in order to avoid conflict with Windows Sockets headers. > > If those fields were

Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

> + > +* net: ``s_addr`` and ``d_addr`` fields of ``rte_ether_hdr`` structure > + will be renamed to ``src_addr`` and ``dst_addr`` respectively in DPDK 20.11 > + in order to avoid conflict with Windows Sockets headers. If those fields were a problem now, there might be others in future. Don't

[dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields

It is proposed to rename fields of `struct rte_ether_hdr`, `s_addr` tp `src_addr` and `d_addr` to `dst_addr`, due to the clash with system macro on Windows. Until remaining is done in 21.11, a workaround can be used. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which conflicts wit