15/01/2021 20:21, Tyler Retzlaff:
> would you also like a patch submitted that stops installing the header. the
> change will be breaking if any other consumers have made the same mistake as
> we did. i'm not sure what dpdk's stance is on pulling headers back out of
> public space.
That's a good q
On Thu, Jan 14, 2021 at 10:55:54AM +, Bruce Richardson wrote:
> > > > This is a private header, it's never exposed---why the change is
> > > > needed (not that I have a strong opinion, though)?
> > >
> > > interesting, i'll look into why/how it is being included and confirm. i
> > > suppose
14/01/2021 19:27, Dmitry Kozlyuk:
> > > If it's a public header then maybe it's missing a @file?
> > >
> > My 2c on this in general...
> >
> > The use of public vs private headers is not always clear, sadly, in DPDK,
> > for historical reasons. With the make builds, libraries picked up headers
> > If it's a public header then maybe it's missing a @file?
> >
> My 2c on this in general...
>
> The use of public vs private headers is not always clear, sadly, in DPDK,
> for historical reasons. With the make builds, libraries picked up headers
> from other libraries via the "include" fold
On Thu, Jan 14, 2021 at 10:05:57AM +0300, Dmitry Kozlyuk wrote:
> On Wed, 13 Jan 2021 21:45:49 -0800, Tyler Retzlaff wrote:
> > On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote:
> > > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote:
> > > > Explicitly cast void * to type *
On Wed, 13 Jan 2021 21:45:49 -0800, Tyler Retzlaff wrote:
> On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote:
> > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote:
> > > Explicitly cast void * to type * so that eal headers may be compiled
> > > as C or C++.
> >
> > Topic
On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote:
> On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote:
> > Explicitly cast void * to type * so that eal headers may be compiled
> > as C or C++.
>
> Topic should probably be "eal/windows".
i'll submit a new rev that changes this
On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote:
> Explicitly cast void * to type * so that eal headers may be compiled
> as C or C++.
Topic should probably be "eal/windows".
Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
Cc: sta...@dpdk.org
> Signed-off-by: Ty
Explicitly cast void * to type * so that eal headers may be compiled
as C or C++.
Signed-off-by: Tyler Retzlaff
---
lib/librte_eal/windows/include/rte_os.h | 2 +-
lib/librte_ethdev/rte_ethdev_pci.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/window
9 matches
Mail list logo
