Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread Tal Shnaiderman
> Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > > External email: Use caution opening links or attachments > > > On Sat, Apr 10, 2021 at 9:55 PM Tal Shnaiderman > wrote: > > > > The macro definitions of the following pthread functions return > > incorrect values from the

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread David Marchand
On Sat, Apr 10, 2021 at 9:55 PM Tal Shnaiderman wrote: > > The macro definitions of the following pthread functions > return incorrect values from the inner function return code. > > while pthread_barrier_init, pthread_barrier_destroy and > pthread_cancel return 0 in a case of success and non zero

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread Dmitry Kozlyuk
2021-04-12 07:59 (UTC+), Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > > > > External email: Use caution opening links or attachments > > > > > > Hi Tal, > > > > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: > > > > ../../../lib/libr

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread Thomas Monjalon
12/04/2021 09:59, Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > > > > External email: Use caution opening links or attachments > > > > > > Hi Tal, > > > > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: > > > > ../../../lib/librte_eal/comm

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-12 Thread Tal Shnaiderman
> Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > > External email: Use caution opening links or attachments > > > Hi Tal, > > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: > > ../../../lib/librte_eal/common/eal_common_thread.c: In function > ‘ctrl_params_free

Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-11 Thread Dmitry Kozlyuk
Hi Tal, Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: ../../../lib/librte_eal/common/eal_common_thread.c: In function ‘ctrl_params_free’: ../../../lib/librte_eal/windows/include/pthread.h:42:2: warning: value computed is not used [-Wunused-value] 42 | !DeleteSynchronizationBarri

[dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-10 Thread Tal Shnaiderman
The macro definitions of the following pthread functions return incorrect values from the inner function return code. while pthread_barrier_init, pthread_barrier_destroy and pthread_cancel return 0 in a case of success and non zero (errno) value otherwise the shimming functions InitializeSynchroni