Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 10/31/2018 5:19 PM, Ferruh Yigit wrote: > rte_strerror uses strerror_r(), and strerror_r() has two version of it. > - XSI-compliant version, (_POSIX_C_SOURCE >= 200112L) && ! _GNU_SOURCE > - GNU-specific version > > Those two has different return types, so the exiting return type check > is no

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 3:45 PM, Jerin Jacob wrote: > -Original Message- >> Date: Fri, 2 Nov 2018 15:39:04 + >> From: Ferruh Yigit >> To: Jerin Jacob >> CC: Bruce Richardson , "dev@dpdk.org" >> , "sta...@dpdk.org" >> Subject: Re:

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 11/1/2018 1:40 PM, Thomas Monjalon wrote: > 01/11/2018 13:46, Ferruh Yigit: >> On 10/31/2018 6:43 PM, Thomas Monjalon wrote: >>> 31/10/2018 19:26, Ferruh Yigit: On 10/31/2018 6:26 PM, Ferruh Yigit wrote: > On 10/31/2018 5:16 PM, Thomas Monjalon wrote: >> 31/10/2018 18:19, Ferruh Yig

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 3:45 PM, Jerin Jacob wrote: > -Original Message- >> Date: Fri, 2 Nov 2018 15:39:04 + >> From: Ferruh Yigit >> To: Jerin Jacob >> CC: Bruce Richardson , "dev@dpdk.org" >> , "sta...@dpdk.org" >> Subject: Re:

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Jerin Jacob
-Original Message- > Date: Fri, 2 Nov 2018 15:39:04 + > From: Ferruh Yigit > To: Jerin Jacob > CC: Bruce Richardson , "dev@dpdk.org" > , "sta...@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH] eal: fix API to get error string > User-Agent: Moz

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 9:51 AM, Jerin Jacob wrote: > -Original Message- >> Date: Wed, 31 Oct 2018 17:19:28 + >> From: Ferruh Yigit >> To: Bruce Richardson >> CC: dev@dpdk.org, Ferruh Yigit , sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH] eal: fix API to get e

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Jerin Jacob
-Original Message- > Date: Wed, 31 Oct 2018 17:19:28 + > From: Ferruh Yigit > To: Bruce Richardson > CC: dev@dpdk.org, Ferruh Yigit , sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix API to get error string > X-Mailer: git-send-email 2.17.2 > > External

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-01 Thread Ferruh Yigit
On 11/1/2018 1:40 PM, Thomas Monjalon wrote: > 01/11/2018 13:46, Ferruh Yigit: >> On 10/31/2018 6:43 PM, Thomas Monjalon wrote: >>> 31/10/2018 19:26, Ferruh Yigit: On 10/31/2018 6:26 PM, Ferruh Yigit wrote: > On 10/31/2018 5:16 PM, Thomas Monjalon wrote: >> 31/10/2018 18:19, Ferruh Yig

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-01 Thread Thomas Monjalon
01/11/2018 13:46, Ferruh Yigit: > On 10/31/2018 6:43 PM, Thomas Monjalon wrote: > > 31/10/2018 19:26, Ferruh Yigit: > >> On 10/31/2018 6:26 PM, Ferruh Yigit wrote: > >>> On 10/31/2018 5:16 PM, Thomas Monjalon wrote: > 31/10/2018 18:19, Ferruh Yigit: > > rte_strerror uses strerror_r(), and

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-01 Thread Ferruh Yigit
On 10/31/2018 6:43 PM, Thomas Monjalon wrote: > 31/10/2018 19:26, Ferruh Yigit: >> On 10/31/2018 6:26 PM, Ferruh Yigit wrote: >>> On 10/31/2018 5:16 PM, Thomas Monjalon wrote: 31/10/2018 18:19, Ferruh Yigit: > rte_strerror uses strerror_r(), and strerror_r() has two version of it. > -

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-10-31 Thread Thomas Monjalon
31/10/2018 19:26, Ferruh Yigit: > On 10/31/2018 6:26 PM, Ferruh Yigit wrote: > > On 10/31/2018 5:16 PM, Thomas Monjalon wrote: > >> 31/10/2018 18:19, Ferruh Yigit: > >>> rte_strerror uses strerror_r(), and strerror_r() has two version of it. > >>> - XSI-compliant version, (_POSIX_C_SOURCE >= 200112

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-10-31 Thread Ferruh Yigit
On 10/31/2018 6:26 PM, Ferruh Yigit wrote: > On 10/31/2018 5:16 PM, Thomas Monjalon wrote: >> 31/10/2018 18:19, Ferruh Yigit: >>> rte_strerror uses strerror_r(), and strerror_r() has two version of it. >>> - XSI-compliant version, (_POSIX_C_SOURCE >= 200112L) && ! _GNU_SOURCE >>> - GNU-specific ve

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-10-31 Thread Ferruh Yigit
On 10/31/2018 5:16 PM, Thomas Monjalon wrote: > 31/10/2018 18:19, Ferruh Yigit: >> rte_strerror uses strerror_r(), and strerror_r() has two version of it. >> - XSI-compliant version, (_POSIX_C_SOURCE >= 200112L) && ! _GNU_SOURCE >> - GNU-specific version >> >> Those two has different return types,

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-10-31 Thread Thomas Monjalon
31/10/2018 18:19, Ferruh Yigit: > rte_strerror uses strerror_r(), and strerror_r() has two version of it. > - XSI-compliant version, (_POSIX_C_SOURCE >= 200112L) && ! _GNU_SOURCE > - GNU-specific version > > Those two has different return types, so the exiting return type check > is not correct f

[dpdk-dev] [PATCH] eal: fix API to get error string

2018-10-31 Thread Ferruh Yigit
rte_strerror uses strerror_r(), and strerror_r() has two version of it. - XSI-compliant version, (_POSIX_C_SOURCE >= 200112L) && ! _GNU_SOURCE - GNU-specific version Those two has different return types, so the exiting return type check is not correct for GNU-specific version. And this is causin