2015-10-13 14:23, David Marchand:
> On Tue, Oct 13, 2015 at 11:13 AM, David Marchand
> > christoph.gysin at gmail.com> wrote:
> >> Is there anything I can do to help getting this merged?
> >
> > This is ok for me, cc-ing Thomas.
>
> Thought I already did, but just in case,
> Acked-by: David March
On Tue, Oct 13, 2015 at 11:13 AM, David Marchand
wrote:
> Hello Christoph,
>
> On Tue, Oct 13, 2015 at 11:10 AM, Christoph Gysin <
> christoph.gysin at gmail.com> wrote:
>
>>
>> Is there anything I can do to help getting this merged?
>>
>
> This is ok for me, cc-ing Thomas.
>
Thought I already d
ptember 29, 2015 7:53 AM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)
>>
>> 'virtual' is a keyword and can't be used if the code is to compile with
>> C++ compilers.
>>
>> If rte_devargs.h wa
Hello Christoph,
On Tue, Oct 13, 2015 at 11:10 AM, Christoph Gysin wrote:
>
> Is there anything I can do to help getting this merged?
>
This is ok for me, cc-ing Thomas.
--
David Marchand
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christoph Gysin
> Sent: Tuesday, September 29, 2015 7:53 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)
>
> 'virtual' is a k
I added the Signed-off, is there anything else missing?
Any chance to get this merged?
On Tue, Sep 29, 2015 at 9:53 AM, Christoph Gysin
wrote:
> 'virtual' is a keyword and can't be used if the code is to compile with
> C++ compilers.
>
> If rte_devargs.h was included in C++ code, compilation wit
'virtual' is a keyword and can't be used if the code is to compile with
C++ compilers.
If rte_devargs.h was included in C++ code, compilation with clang++
failed with an error. g++ did not fail, but only because of a bug
that treats it as an anonymous struct with a decl-specifier which it
ignores.
Hello Christoph,
On Sat, Sep 26, 2015 at 3:09 PM, Christoph Gysin
wrote:
> 'virtual' is a keyword and can't be used if the code is to compile with
> C++ compilers.
>
> If rte_devargs.h was included in C++ code, compilation with clang++
> failed with an error. g++ did not fail, but only because o
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christoph Gysin
> Sent: Saturday, September 26, 2015 2:10 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)
>
> 'virtual' is a k
'virtual' is a keyword and can't be used if the code is to compile with
C++ compilers.
If rte_devargs.h was included in C++ code, compilation with clang++
failed with an error. g++ did not fail, but only because of a bug
that treats it as an anonymous struct with a decl-specifier which it
ignores.
'virtual' is a keyword and can't be used if the code is to compile with
C++ compilers.
If rte_devargs.h was included in C++ code, compilation with clang++
failed with an error. g++ did not fail, but only because of a bug
that treats it as an anonymous struct with a decl-specifier which it
ignores.
11 matches
Mail list logo
