Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers

2020-03-17 Thread Thomas Monjalon
17/03/2020 08:09, Dmitry Kozlyuk: > > > This case is now better fixed with a patch removing EAL dependencies > > > from the PCI library, which drops rte_common.h inclusion from pmdinfogen: > > > http://patches.dpdk.org/patch/66701/ > > > > Actually rte_common.h is directly included by > > b

Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers

2020-03-17 Thread Dmitry Kozlyuk
> > This case is now better fixed with a patch removing EAL dependencies > > from the PCI library, which drops rte_common.h inclusion from pmdinfogen: > > http://patches.dpdk.org/patch/66701/ > > Actually rte_common.h is directly included by > buildtools/pmdinfogen/pmdinfogen.c > so we need

Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers

2020-03-16 Thread Thomas Monjalon
16/03/2020 13:04, Thomas Monjalon: > RTE_TOOLCHAIN_* macros are defining the target compiler. > Some API may be used in a host application like pmdinfogen. > That's why the the public headers should check the effective compiler > in use instead of the target compiler. > > Detecting the compiler wi

[dpdk-dev] [PATCH] eal: fix compiler detection in public headers

2020-03-16 Thread Thomas Monjalon
RTE_TOOLCHAIN_* macros are defining the target compiler. Some API may be used in a host application like pmdinfogen. That's why the the public headers should check the effective compiler in use instead of the target compiler. Detecting the compiler with macros is easy, except for __GNUC__ which is