Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-12 Thread Sexton, Rory
: dev On Behalf Of Sexton, Rory Sent: Wednesday, December 11, 2019 4:31 PM To: Ori Kam ; dev@dpdk.org Cc: Zhang, Qi Z ; Xing, Beilei ; Adrien Mazarguil ; Jagus, DariuszX Subject: Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API Hi Ori, See comments below. Regards, Rory

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-11 Thread Sexton, Rory
Hi Ori, See comments below. Regards, Rory > > > > > > +/** > > > > > > + * RTE_FLOW_ITEM_TYPE_L2TPV3. > > > > > > + * > > > > > > + * Matches a L2TPv3 header. > > > > > > + */ > > > > > > +struct rte_flow_item_l2tpv3 { > > > > > > + rte_be32_t session_id; /**< Session ID. */ }; > > > > > > > >

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-11 Thread Ori Kam
Hi Rory, PSB > -Original Message- > From: Sexton, Rory > Sent: Wednesday, December 11, 2019 1:36 PM > To: Ori Kam ; dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Adrien Mazarguil ; Jagus, DariuszX > > Subject: RE: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-11 Thread Sexton, Rory
Hi Ori, See my comments below. Regards, Rory >> >>> One general question why do we want to support only v3 and not also v2? >> l2tpv3 is more widely used as a tunneling protocol hence it's inclusion. >> A specific example is the cable industry where DOCSIS cable traffic is >> encapsulated usin

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-10 Thread Ori Kam
Hi Rory, > -Original Message- > From: Sexton, Rory > Sent: Tuesday, December 10, 2019 4:52 PM > To: Ori Kam ; dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Adrien Mazarguil ; Jagus, DariuszX > > Subject: RE: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-10 Thread Sexton, Rory
Hi Ori, > One general question why do we want to support only v3 and not also v2? l2tpv3 is more widely used as a tunneling protocol hence it's inclusion. A specific example is the cable industry where DOCSIS cable traffic is encapsulated using depi and uepi protocols which both make use of l2tpv

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-10 Thread Ori Kam
l.com; beilei.x...@intel.com; rory.sex...@intel.com; > Adrien Mazarguil ; Dariusz Jagus > > Subject: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API > > - RTE_FLOW_ITEM_TYPE_L2TPV3: matches a L2TPv3 header > > Signed-off-by: Rory Sexton > Signed-off-by: Dariusz Jagu

[dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-04 Thread Rory Sexton
- RTE_FLOW_ITEM_TYPE_L2TPV3: matches a L2TPv3 header Signed-off-by: Rory Sexton Signed-off-by: Dariusz Jagus --- app/test-pmd/cmdline_flow.c | 28 + doc/guides/prog_guide/rte_flow.rst | 8 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++