[dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats

2016-01-20 Thread Thomas Monjalon
2016-01-20 10:03, Kyle Larose: > Hi Harry, > > On Wed, Jan 20, 2016 at 9:45 AM, Van Haaren, Harry > wrote: > > Hi Kyle, > > > > > In theory we could create a new API for this, but I think the current > > xstats API is a good fit for exposing this info, so why create extra APIs? > > As a client

[dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats

2016-01-20 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > 2016-01-20 10:03, Kyle Larose: > > We already have the rte_eth_link_get function. Why not let users > > continue to use that? It's well defined, it is simple, and it is > > consistent. > > +1 Ok, no problem. I'll mark the link-statu

[dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats

2016-01-20 Thread Van Haaren, Harry
Hi Kyle, > From: Kyle Larose [mailto:eomereadig at gmail.com] > On Wed, Jan 20, 2016 at 9:28 AM, Harry van Haaren > wrote: > > This patch exposes link duplex, speed, and status via the > > existing xstats API. > > I'm slightly confused by this. Why are we exposing operational > properties of the

[dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats

2016-01-20 Thread Harry van Haaren
This patch exposes link duplex, speed, and status via the existing xstats API. Signed-off-by: Harry van Haaren --- doc/guides/rel_notes/release_2_3.rst | 1 + lib/librte_ether/rte_ethdev.c| 29 ++--- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a

[dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats

2016-01-20 Thread Stephen Hemminger
On Wed, 20 Jan 2016 16:13:34 +0100 Thomas Monjalon wrote: > > We already have the rte_eth_link_get function. Why not let users > > continue to use that? It's well defined, it is simple, and it is > > consistent. +1 API's should not duplicate results (DRY) That said, it would be useful to hav

[dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats

2016-01-20 Thread Kyle Larose
Hi Harry, On Wed, Jan 20, 2016 at 9:45 AM, Van Haaren, Harry wrote: > Hi Kyle, > > In theory we could create a new API for this, but I think the current xstats > API is a good fit for exposing this info, so why create extra APIs? As a > client of the DPDK API, I would prefer more statistics in

[dpdk-dev] [PATCH] ethdev: expose link status and speed using xstats

2016-01-20 Thread Kyle Larose
On Wed, Jan 20, 2016 at 9:28 AM, Harry van Haaren wrote: > This patch exposes link duplex, speed, and status via the > existing xstats API. > I'm slightly confused by this. Why are we exposing operational properties of the chip through an API which I thought was primarily targeting statistics? Wh