Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-15 Thread Ivan Malov
On Wed, 10 Nov 2021, Ferruh Yigit wrote: On 11/2/2021 5:04 PM, David Marchand wrote: On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko wrote: IMHO, spamming of testpmd logs in described case should be fixed in testpmd itself to avoid logs in the case of ENOTSUP. That's it. I think we should n

RE: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-15 Thread Ori Kam
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 15, 2021 5:09 PM > Subject: Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick > transfer proxy API > > 15/11/2021 15:15, Ivan Malov: > > On Wed, 10 Nov 2021, Ferruh Yig

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-15 Thread Thomas Monjalon
15/11/2021 15:15, Ivan Malov: > On Wed, 10 Nov 2021, Ferruh Yigit wrote: > > > On 11/2/2021 5:04 PM, David Marchand wrote: > >> On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko > >> wrote: > > IMHO, spamming of testpmd logs in described case should be fixed > > in testpmd itself to avoid l

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-10 Thread Ferruh Yigit
On 11/2/2021 5:04 PM, David Marchand wrote: On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko wrote: IMHO, spamming of testpmd logs in described case should be fixed in testpmd itself to avoid logs in the case of ENOTSUP. That's it. I think we should not call this API in testpmd if not doing rt

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-02 Thread David Marchand
On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko wrote: > >> IMHO, spamming of testpmd logs in described case should be fixed > >> in testpmd itself to avoid logs in the case of ENOTSUP. That's it. > > > > I think we should not call this API in testpmd > > if not doing rte_flow transfer rule. > > >

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-02 Thread Andrew Rybchenko
On 11/2/21 6:45 PM, Thomas Monjalon wrote: 01/11/2021 10:41, Andrew Rybchenko: On 10/27/21 12:00 PM, Ivan Malov wrote: There are PMDs which do not support flow offloads at all. In such cases, the API in question returns ENOTSUP. This is too loud. Restructure the code to avoid spamming logs. Fi

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-02 Thread Thomas Monjalon
01/11/2021 10:41, Andrew Rybchenko: > On 10/27/21 12:00 PM, Ivan Malov wrote: > > There are PMDs which do not support flow offloads at all. > > In such cases, the API in question returns ENOTSUP. This > > is too loud. Restructure the code to avoid spamming logs. > > > > Fixes: 1179f05cc9a0 ("ethde

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-01 Thread Andrew Rybchenko
On 10/27/21 12:00 PM, Ivan Malov wrote: There are PMDs which do not support flow offloads at all. In such cases, the API in question returns ENOTSUP. This is too loud. Restructure the code to avoid spamming logs. Fixes: 1179f05cc9a0 ("ethdev: query proxy port to manage transfer flows") Signed-o

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-10-29 Thread Thomas Monjalon
28/10/2021 18:24, Ivan Malov: > On 27/10/2021 13:57, Thomas Monjalon wrote: > > 27/10/2021 11:55, Ivan Malov: > >> On 27/10/2021 12:46, Thomas Monjalon wrote: > >>> 27/10/2021 11:00, Ivan Malov: > -if (unlikely(ops == NULL)) > -return -rte_errno; > - > -

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-10-28 Thread Ivan Malov
Good day to you, Thomas. On 27/10/2021 13:57, Thomas Monjalon wrote: 27/10/2021 11:55, Ivan Malov: Hi Thomas, On 27/10/2021 12:46, Thomas Monjalon wrote: 27/10/2021 11:00, Ivan Malov: There are PMDs which do not support flow offloads at all. In such cases, the API in question returns ENOTSUP

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-10-27 Thread Thomas Monjalon
27/10/2021 11:55, Ivan Malov: > Hi Thomas, > > On 27/10/2021 12:46, Thomas Monjalon wrote: > > 27/10/2021 11:00, Ivan Malov: > >> There are PMDs which do not support flow offloads at all. > >> In such cases, the API in question returns ENOTSUP. This > >> is too loud. Restructure the code to avoid

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-10-27 Thread Ivan Malov
Hi Thomas, On 27/10/2021 12:46, Thomas Monjalon wrote: 27/10/2021 11:00, Ivan Malov: There are PMDs which do not support flow offloads at all. In such cases, the API in question returns ENOTSUP. This is too loud. Restructure the code to avoid spamming logs. Fixes: 1179f05cc9a0 ("ethdev: query

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-10-27 Thread Thomas Monjalon
27/10/2021 11:00, Ivan Malov: > There are PMDs which do not support flow offloads at all. > In such cases, the API in question returns ENOTSUP. This > is too loud. Restructure the code to avoid spamming logs. > > Fixes: 1179f05cc9a0 ("ethdev: query proxy port to manage transfer flows") > > Signed

[dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-10-27 Thread Ivan Malov
There are PMDs which do not support flow offloads at all. In such cases, the API in question returns ENOTSUP. This is too loud. Restructure the code to avoid spamming logs. Fixes: 1179f05cc9a0 ("ethdev: query proxy port to manage transfer flows") Signed-off-by: Ivan Malov --- lib/ethdev/rte_flo