Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-04-09 Thread Nélio Laranjeiro
On Fri, Apr 06, 2018 at 05:21:48PM +0200, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addr

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-04-06 Thread Olivier Matz
On Fri, Apr 06, 2018 at 05:21:48PM +0200, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_add

[dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-04-06 Thread Olivier Matz
Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if the operation is successful. The patch also updates all th

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-03-28 Thread Olivier Matz
Hi Ferruh, On Mon, Mar 26, 2018 at 07:39:00PM +0100, Ferruh Yigit wrote: > On 2/27/2018 3:11 PM, Olivier Matz wrote: > > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > > return code is added to notify the caller (librte_ether) if an error > > occurred in the PMD. > > >

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-03-26 Thread Ferruh Yigit
On 2/27/2018 3:11 PM, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addrs[0] > only if the o

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-03-16 Thread Andrew Rybchenko
Hi Olivier, On 02/27/2018 06:11 PM, Olivier Matz wrote: Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-03-06 Thread Tomasz Duszynski
Hi, Some comments inline. On Tue, Feb 27, 2018 at 04:11:29PM +0100, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now co

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-03-05 Thread Adrien Mazarguil
On Tue, Feb 27, 2018 at 04:11:29PM +0100, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addr

[dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-02-27 Thread Olivier Matz
Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if the operation is successful. The patch also updates all th