Re: [dpdk-dev] [PATCH] ethdev: warn only once for badly behaving applications

2021-10-27 Thread David Marchand
On Wed, Oct 27, 2021 at 10:16 AM Olivier Matz wrote: > > Do you have the explanation or can you point me at some standard > > explaining the difference in treatment? > > Let me try an explanation, hope it is the correct one. > > In the first case, this is an assignment as described in 6.5.16 of >

Re: [dpdk-dev] [PATCH] ethdev: warn only once for badly behaving applications

2021-10-27 Thread Olivier Matz
Hi, On Wed, Oct 27, 2021 at 09:20:52AM +0200, David Marchand wrote: > On Tue, Oct 26, 2021 at 5:57 PM Thomas Monjalon wrote: > > > > 26/10/2021 16:58, David Marchand: > > > Warning continuously is a pain when developping or if a unit test > > > is/gets broken. > > > > > > It could also be a probl

Re: [dpdk-dev] [PATCH] ethdev: warn only once for badly behaving applications

2021-10-27 Thread David Marchand
On Tue, Oct 26, 2021 at 7:10 PM Ananyev, Konstantin wrote: > > static uint16_t > > -dummy_eth_rx_burst(__rte_unused void *rxq, > > +dummy_eth_rx_burst(void *rxq, > > __rte_unused struct rte_mbuf **rx_pkts, > > __rte_unused uint16_t nb_pkts) > > { > > - RTE_ETHDEV_

Re: [dpdk-dev] [PATCH] ethdev: warn only once for badly behaving applications

2021-10-27 Thread David Marchand
On Tue, Oct 26, 2021 at 5:57 PM Thomas Monjalon wrote: > > 26/10/2021 16:58, David Marchand: > > Warning continuously is a pain when developping or if a unit test > > is/gets broken. > > > > It could also be a problem if application behaves badly only in some > > corner cases and a DoS results of

Re: [dpdk-dev] [PATCH] ethdev: warn only once for badly behaving applications

2021-10-26 Thread Ananyev, Konstantin
> > Warning continuously is a pain when developping or if a unit test > is/gets broken. > > It could also be a problem if application behaves badly only in some > corner cases and a DoS results of those logs being continuously displayed. > > Let's warn once per port and per rx/tx. > > Getting

Re: [dpdk-dev] [PATCH] ethdev: warn only once for badly behaving applications

2021-10-26 Thread Thomas Monjalon
26/10/2021 16:58, David Marchand: > Warning continuously is a pain when developping or if a unit test > is/gets broken. > > It could also be a problem if application behaves badly only in some > corner cases and a DoS results of those logs being continuously displayed. > > Let's warn once per por

[dpdk-dev] [PATCH] ethdev: warn only once for badly behaving applications

2021-10-26 Thread David Marchand
Warning continuously is a pain when developping or if a unit test is/gets broken. It could also be a problem if application behaves badly only in some corner cases and a DoS results of those logs being continuously displayed. Let's warn once per port and per rx/tx. Getting such a log is scary, b