Re: [dpdk-dev] [PATCH] ether: check the first segment length on SW VLAN insertion

2020-09-14 Thread Ferruh Yigit
On 6/25/2020 1:27 PM, Andrew Rybchenko wrote: > On 5/29/20 8:43 AM, Stephen Hemminger wrote: >> On Wed, 27 May 2020 15:31:41 +0100 >> Andrew Rybchenko wrote: >> >>> SW VLAN insertion relies on Ethernet addresses location in contigous >>> memory (do not split across mbuf segments). There is no any

Re: [dpdk-dev] [PATCH] ether: check the first segment length on SW VLAN insertion

2020-06-25 Thread Andrew Rybchenko
On 5/29/20 8:43 AM, Stephen Hemminger wrote: > On Wed, 27 May 2020 15:31:41 +0100 > Andrew Rybchenko wrote: > >> SW VLAN insertion relies on Ethernet addresses location in contigous >> memory (do not split across mbuf segments). There is no any formal >> requirements on data location and mbuf str

Re: [dpdk-dev] [PATCH] ether: check the first segment length on SW VLAN insertion

2020-05-28 Thread Stephen Hemminger
On Wed, 27 May 2020 15:31:41 +0100 Andrew Rybchenko wrote: > SW VLAN insertion relies on Ethernet addresses location in contigous > memory (do not split across mbuf segments). There is no any formal > requirements on data location and mbuf structure which guarantee it. > So, check it explicitly t

[dpdk-dev] [PATCH] ether: check the first segment length on SW VLAN insertion

2020-05-27 Thread Andrew Rybchenko
SW VLAN insertion relies on Ethernet addresses location in contigous memory (do not split across mbuf segments). There is no any formal requirements on data location and mbuf structure which guarantee it. So, check it explicitly to avoid corrupted packets if the condition is violated. Typically sof