Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Thursday, March 29, 2018 11:06 AM > To: Anoob Joseph ; Akhil Goyal > > Cc: Doherty, Declan ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: Re: [dpdk-

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-29 Thread Radu Nicolau
On 3/28/2018 3:28 PM, Anoob Joseph wrote: Hi Akhil, Radu, Did you get time to review the patch? Thanks, Anoob On 23/03/18 11:20, Anoob Joseph wrote: Removing redundant strncmp in parsing long arguments. The getopt library provides means to identify long options using the "val" field of struc

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-28 Thread Anoob Joseph
Hi Akhil, Radu, Did you get time to review the patch? Thanks, Anoob On 23/03/18 11:20, Anoob Joseph wrote: Removing redundant strncmp in parsing long arguments. The getopt library provides means to identify long options using the "val" field of structure option. The existing code gets 0 as "va

[dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-22 Thread Anoob Joseph
Removing redundant strncmp in parsing long arguments. The getopt library provides means to identify long options using the "val" field of structure option. The existing code gets 0 as "val" for all long arguments and then uses strncmp to figure out which long option was being referred to. Fixing th