Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-08 Thread Hu, Jiayu
ject: RE: [dpdk-dev] [PATCH] gro: add missing invalid packet checks > > > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananye

Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-08 Thread Morten Brørup
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > > > Konstantin > > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > > > > > > >

Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-08 Thread Ananyev, Konstantin
ger > > Cc: dev@dpdk.org; Bie, Tiwei; Richardson, Bruce; sta...@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks > > > > > > > > > > > > > > > > -Original Message- > > > > From: Stephen

Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-08 Thread Hu, Jiayu
ger > > Cc: dev@dpdk.org; Bie, Tiwei; Richardson, Bruce; sta...@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks > > > > > > > > > > > > > > > > -Original Message- > > > > From: Stephen Hemminge

Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-08 Thread Morten Brørup
t; > > Cc: dev@dpdk.org; Bie, Tiwei ; Richardson, > Bruce > > > ; sta...@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] gro: add missing invalid packet > checks > > > > > > On Tue, 8 Jan 2019 14:08:45 +0800 > > > Jiayu Hu wrote: > > > > >

Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-08 Thread Ananyev, Konstantin
> > > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Tuesday, January 8, 2019 2:32 PM > > To: Hu, Jiayu > > Cc: dev@dpdk.org; Bie, Tiwei ; Richardson, Bruce > > ; sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-08 Thread Hu, Jiayu
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, January 8, 2019 2:32 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Bie, Tiwei ; Richardson, Bruce > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] gro: add missing

Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-07 Thread Stephen Hemminger
On Tue, 8 Jan 2019 14:08:45 +0800 Jiayu Hu wrote: > + /* > + * Don't process the packet whose Ethernet, IPv4 and TCP header > + * lengths are invalid. In addition, if the IPv4 header contains > + * Options, the packet shouldn't be processed. > + */ > + if (unlikely(IL

[dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-07 Thread Jiayu Hu
Currently, GRO library doesn't check if input packets have invalid headers. The packets with invalid headers will also be processed by GRO. However, GRO shouldn't process invalid packets. This patch adds missing invalid packet checks. Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") Fixes: 9e0b9