Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation

2019-01-07 Thread Stephen Hemminger
On Tue, 8 Jan 2019 01:22:18 + "Hu, Jiayu" wrote: > > -Original Message- > > From: Richardson, Bruce > > Sent: Monday, January 7, 2019 10:30 PM > > To: Hu, Jiayu > > Cc: dev@dpdk.org; Bie, Tiwei ; sta...@dpdk.org > > Subject: Re: [dpdk

Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation

2019-01-07 Thread Hu, Jiayu
> -Original Message- > From: Richardson, Bruce > Sent: Monday, January 7, 2019 10:30 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Bie, Tiwei ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length > calculation > > On Fri, Jan 0

Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation

2019-01-07 Thread Bruce Richardson
On Fri, Jan 04, 2019 at 09:57:16AM +0800, Jiayu Hu wrote: > If we receive a packet with an invalid TCP header, whose > TCP header length is less than 20 bytes (the minimal TCP > header length), the calculated TCP Options length will > overflow and result in incorrect reassembly behaviors. Please e

[dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation

2019-01-03 Thread Jiayu Hu
If we receive a packet with an invalid TCP header, whose TCP header length is less than 20 bytes (the minimal TCP header length), the calculated TCP Options length will overflow and result in incorrect reassembly behaviors. Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") Fixes: 9e0b9d2ec0f4 ("gr