Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-19 Thread yang_y_yi
At 2020-10-19 16:47:55, "Ananyev, Konstantin" wrote: > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 19, 2020 9:44 AM > To: Ananyev, Konstantin > Subject: FW: Re:RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments > attach to > > > > From: yang

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 19, 2020 9:44 AM > To: Ananyev, Konstantin > Subject: FW: Re:RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments > attach to > > > > From: yang_y_yi mailto:yang_y...@163.com>> > Sent: Monday, Octobe

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-18 Thread yang_y_yi
At 2020-10-19 11:17:48, "Hu, Jiayu" wrote: > > >> -Original Message- >> From: Ananyev, Konstantin >> Sent: Friday, October 16, 2020 4:31 PM >> To: Hu, Jiayu ; yang_y_yi >> Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; >> yangy...@inspur.com >> Subject: RE: Re:RE: [PATCH]

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-18 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, October 16, 2020 4:31 PM > To: Hu, Jiayu ; yang_y_yi > Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; > yangy...@inspur.com > Subject: RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments attach to

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-18 Thread yang_y_yi
At 2020-10-16 08:53:00, "Hu, Jiayu" wrote: > > >> -Original Message- >> From: Ananyev, Konstantin >> Sent: Friday, October 16, 2020 12:16 AM >> To: Hu, Jiayu ; yang_y_yi >> Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; >> yangy...@inspur.com >> Subject: RE: Re:RE: [PATCH

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-18 Thread yang_y_yi
At 2020-10-16 00:16:03, "Ananyev, Konstantin" wrote: > > >> >> > -Original Message- >> > From: Ananyev, Konstantin >> > Sent: Wednesday, October 14, 2020 8:06 PM >> > To: yang_y_yi ; Hu, Jiayu >> > Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; >> > yangy...@inspur.com

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-16 Thread Ananyev, Konstantin
> > > > > > > > > > > I think it isn't a good idea to free it in rte_gso_segment, maybe > > application > > > > will continue to use this pkt for other purpose, rte_gso_segment > > > > > can't make decision for application without any notice, it is better > > > > > to > > return > > > > this d

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-15 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, October 16, 2020 12:16 AM > To: Hu, Jiayu ; yang_y_yi > Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; > yangy...@inspur.com > Subject: RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments attach to

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-15 Thread Ananyev, Konstantin
> > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Wednesday, October 14, 2020 8:06 PM > > To: yang_y_yi ; Hu, Jiayu > > Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; > > yangy...@inspur.com > > Subject: RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-14 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, October 14, 2020 8:06 PM > To: yang_y_yi ; Hu, Jiayu > Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; > yangy...@inspur.com > Subject: RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments attach

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-14 Thread Ananyev, Konstantin
> From: yang_y_yi > Sent: Wednesday, October 14, 2020 3:56 AM > To: Hu, Jiayu > Cc: Ananyev, Konstantin ; dev@dpdk.org; > olivier.m...@6wind.com; tho...@monjalon.net; > yangy...@inspur.com > Subject: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments attach to > > I think it isn't a good

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-13 Thread yang_y_yi
I think it isn't a good idea to free it in rte_gso_segment, maybe application will continue to use this pkt for other purpose, rte_gso_segment can't make decision for application without any notice, it is better to return this decision right backt to application. At 2020-10-

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-13 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, October 13, 2020 11:39 PM > To: Hu, Jiayu ; yang_y...@163.com; dev@dpdk.org > Cc: mark.b.kavan...@intel.com; olivier.m...@6wind.com; > tho...@monjalon.net; yangy...@inspur.com > Subject: RE: [PATCH] gso: fix free issue of

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-13 Thread Ananyev, Konstantin
> > rte_gso_segment decreased refcnt of pkt by one, but > > it is wrong if pkt is external mbuf, pkt won't be > > freed because of incorrect refcnt, the result is > > application can't allocate mbuf from mempool because > > mbufs in mempool are run out of. > > > > One correct way is application s

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-13 Thread Hu, Jiayu
> -Original Message- > From: yang_y...@163.com > Sent: Saturday, October 10, 2020 11:10 AM > To: dev@dpdk.org > Cc: Hu, Jiayu ; mark.b.kavan...@intel.com; Ananyev, > Konstantin ; olivier.m...@6wind.com; > tho...@monjalon.net; yangy...@inspur.com; yang_y...@163.com > Subject: [PATCH] gso

[dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-09 Thread yang_y_yi
From: Yi Yang rte_gso_segment decreased refcnt of pkt by one, but it is wrong if pkt is external mbuf, pkt won't be freed because of incorrect refcnt, the result is application can't allocate mbuf from mempool because mbufs in mempool are run out of. One correct way is application should call rt