Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2021-03-24 Thread Thomas Monjalon
24/05/2020 17:27, Thomas Monjalon: > 01/05/2020 22:43, Ananyev, Konstantin: > > > > > > > > When fragmenting ipv4 packet, the data offset should be calculated through > > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > > > > > Fixes: 4c38e5532a07 ("ip_frag: refact

Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-24 Thread Thomas Monjalon
01/05/2020 22:43, Ananyev, Konstantin: > > > > > When fragmenting ipv4 packet, the data offset should be calculated through > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > > > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper > > library"

[dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-04 Thread Pu Xu
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). Fixes: a7c528e5d71f ("net: add rte prefix to IP structure") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Pu Xu <583493...@qq.com>

[dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-04 Thread Pu Xu
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). Fixes: a7c528e5d71f ("net: add rte prefix to IP structure") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Pu Xu <583493...@qq.com>

Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-01 Thread Ananyev, Konstantin
> > When fragmenting ipv4 packet, the data offset should be calculated through > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper > library") > Cc: anatoly.bura...@intel.com > Cc: sta...@dpdk.

[dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-01 Thread Pu Xu
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-01 Thread Pu Xu
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org --- lib/librte

Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-01 Thread Ananyev, Konstantin
Hi, > When fragmenting ipv4 packet, the data offset should be calculated through > the ihl field in ip header rather than using sizeof(struct > rte_ipv4_hdr). There are few checkpatch errro/warnings: http://mails.dpdk.org/archives/test-report/2020-May/129803.html please fix. > > Fixes: a7c528e

[dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-01 Thread Pu Xu
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). Fixes: a7c528e5d71f ("net: add rte prefix to IP structure") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Pu Xu <583493...@qq.com>

Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-01 Thread Ananyev, Konstantin
> > When fragmenting ipv4 packet, the data offset should be calculated through > the ihl field in ip header rather than using sizeof(struct > rte_ipv4_hdr). Patch looks good to me... Though by some reason I couldn't find it at DPDK patchwork... http://patches.dpdk.org/project/dpdk/list/ Did y