[dpdk-dev] [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54)

2014-08-01 Thread Thomas Monjalon
2014-07-24 16:31, Buriez, Patrice: > > Why not this simpler form? > > $(shell lsb_release -si 2>/dev/null) > > I didn't want "make" to stop on error or to display a warning if lsb_release > is not available on other distributions. > I must admit that I focused on identifying the exact 5-tuple >

[dpdk-dev] [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54)

2014-07-24 Thread Thomas Monjalon
Hi Chris, 2014-07-24 08:20, Chris Wright: > * Pablo de Lara (pablo.de.lara.guarch at intel.com) wrote: > > Signed-off-by: Patrice Buriez > > Just a mechanical nitpick on DCO. Pablo, this patch appears to be > written by Patrice. If so, it should begin with "From: Patrice Buriez > " and should

[dpdk-dev] [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54)

2014-07-24 Thread Thomas Monjalon
2014-07-24 16:54, Thomas Monjalon: > > Unlike RHEL_RELEASE_CODE, there is no such UBUNTU_RELEASE_CODE available > > out of > > the box, so it needs to be crafted from the Makefile > > Similarly, UBUNTU_KERNEL_CODE is generated with ABI and upload numbers. > > It's quite amazing to see that Linux

[dpdk-dev] [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54)

2014-07-24 Thread Thomas Monjalon
> Unlike RHEL_RELEASE_CODE, there is no such UBUNTU_RELEASE_CODE available out > of > the box, so it needs to be crafted from the Makefile > Similarly, UBUNTU_KERNEL_CODE is generated with ABI and upload numbers. It's quite amazing to see that Linux distributions do backports and do not provide a

[dpdk-dev] [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54)

2014-07-24 Thread Pablo de Lara
Recent Ubuntu kernel 3.13.0-30.54, although based on Linux kernel 3.13.11, already provides skb_set_hash() inline function, slightly different than the one provided by lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h Ubuntu kernel 3.13.0-30.54 provides: * i40e/i40evf: i40e implementation for

[dpdk-dev] [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54)

2014-07-24 Thread Chris Wright
* Thomas Monjalon (thomas.monjalon at 6wind.com) wrote: > 2014-07-24 08:20, Chris Wright: > > * Pablo de Lara (pablo.de.lara.guarch at intel.com) wrote: > > > Signed-off-by: Patrice Buriez > > > > Just a mechanical nitpick on DCO. Pablo, this patch appears to be > > written by Patrice. If so, i

[dpdk-dev] [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54)

2014-07-24 Thread Chris Wright
* Pablo de Lara (pablo.de.lara.guarch at intel.com) wrote: > Signed-off-by: Patrice Buriez Just a mechanical nitpick on DCO. Pablo, this patch appears to be written by Patrice. If so, it should begin with "From: Patrice Buriez " and should include your own Signed-off-by. thanks, -chris > ---