Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating

2020-05-24 Thread Thomas Monjalon
24/05/2020 17:31, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Sunday, May 24, 2020 5:12 PM > > > > 15/05/2020 15:08, guohongzhi: > > > 1.rte_ipv4_cksum will return invalid checksum value like 0x.(rfc1624) > > > 2.__rte_raw_cksum should consider Big Endian. >

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating

2020-05-24 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, May 24, 2020 5:12 PM > > 15/05/2020 15:08, guohongzhi: > > 1.rte_ipv4_cksum will return invalid checksum value like 0x.(rfc1624) > > 2.__rte_raw_cksum should consider Big Endian. > > 3.checksum 0x is invalid for udp, but

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating

2020-05-24 Thread Thomas Monjalon
15/05/2020 15:08, guohongzhi: > 1.rte_ipv4_cksum will return invalid checksum value like 0x.(rfc1624) > 2.__rte_raw_cksum should consider Big Endian. > 3.checksum 0x is invalid for udp, but valid for tcp.(rfc768) Please consider doing 3 patches, thanks. It was sent late for 20.05, I prefe

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating

2020-05-15 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of guohongzhi > Sent: Friday, May 15, 2020 3:09 PM > > 1.rte_ipv4_cksum will return invalid checksum value like > 0x.(rfc1624) > 2.__rte_raw_cksum should consider Big Endian. > 3.checksum 0x is invalid for udp, but valid for tcp.(rfc768)

[dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating

2020-05-15 Thread guohongzhi
1.rte_ipv4_cksum will return invalid checksum value like 0x.(rfc1624) 2.__rte_raw_cksum should consider Big Endian. 3.checksum 0x is invalid for udp, but valid for tcp.(rfc768) Signed-off-by: guohongzhi --- lib/librte_net/rte_ip.h | 15 ++- 1 file changed, 10 insertions(+), 5