Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-22 Thread Thomas Monjalon
15/04/2019 11:21, Hunt, David: > On 12/4/2019 4:57 PM, Lee Daly wrote: > > This patch will ensure the correct max frequency of a core is set in > > the lcore_power_info struct when disabling turbo, while using the > > intel pstate driver. > > > > Fixes: e6c6dc0f96c8 ("power: add p-state driver comp

Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-16 Thread Bruce Richardson
On Mon, Apr 15, 2019 at 09:36:40AM -0700, Stephen Hemminger wrote: > On Mon, 15 Apr 2019 17:11:10 +0100 > "Liang, Ma" wrote: > > > > pi->turbo_enable = 0; > > > > > > - > > > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) { > > You (don't) need (so many) parenthesis. True (but it doesn

Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-15 Thread Stephen Hemminger
On Mon, 15 Apr 2019 17:11:10 +0100 "Liang, Ma" wrote: > > pi->turbo_enable = 0; > > > > - > > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) { You (don't) need (so many) parenthesis.

Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-15 Thread Liang, Ma
Acked-by: Liang Ma On 12 Apr 16:57, Lee Daly wrote: > This patch will ensure the correct max frequency of a core is set in > the lcore_power_info struct when disabling turbo, while using the > intel pstate driver. > > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > Cc: liang.

Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-15 Thread Hunt, David
On 12/4/2019 4:57 PM, Lee Daly wrote: This patch will ensure the correct max frequency of a core is set in the lcore_power_info struct when disabling turbo, while using the intel pstate driver. Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") Cc: liang.j...@intel.com Cc: sta...@

[dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-12 Thread Lee Daly
This patch will ensure the correct max frequency of a core is set in the lcore_power_info struct when disabling turbo, while using the intel pstate driver. Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") Cc: liang.j...@intel.com Cc: sta...@dpdk.org Signed-off-by: Lee Daly --- li