Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics

2019-06-18 Thread Thomas Monjalon
18/06/2019 18:55, Pattan, Reshma: > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > I see some errors with GCC: > > On which GCC version the errors are shown? GCC 8.3 Given the type of the errors I think it should be visible with older versions. > >

Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics

2019-06-18 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > I see some errors with GCC: On which GCC version the errors are shown? > > rte_telemetry_parser.c:362:27: error: unused variable ‘p’ > > rte_telemetry.c:550:11: error: unused variable ‘i’ > > rte_tele

Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics

2019-06-18 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > I see some errors with GCC: > > rte_telemetry_parser.c:362:27: error: unused variable ‘p’ > > rte_telemetry.c:550:11: error: unused variable ‘i’ > > rte_telemetry.c:613:16: error: comparison of integer ex

Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics

2019-06-18 Thread Thomas Monjalon
17/05/2019 19:07, Reshma Pattan: > telemetry has support for fetching port based stats > from metrics library. > > Metrics library also has global stats which are > not fetched by telemetry, so extend telemetry to > fetch the global metrics. > > Signed-off-by: Reshma Pattan > --- I see some err

Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics

2019-05-31 Thread Laatz, Kevin
On 17/05/2019 17:07, Reshma Pattan wrote: telemetry has support for fetching port based stats from metrics library. Metrics library also has global stats which are not fetched by telemetry, so extend telemetry to fetch the global metrics. Signed-off-by: Reshma Pattan --- doc/guides/howto/t

[dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics

2019-05-17 Thread Reshma Pattan
telemetry has support for fetching port based stats from metrics library. Metrics library also has global stats which are not fetched by telemetry, so extend telemetry to fetch the global metrics. Signed-off-by: Reshma Pattan --- doc/guides/howto/telemetry.rst| 9 +- doc/guide