Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-05-08 Thread Ferruh Yigit
On 1/8/2020 1:58 PM, Laurent Hardy wrote: > > On 1/8/20 2:06 PM, Thomas Monjalon wrote: >> 08/01/2020 13:59, Ferruh Yigit: >>> On 1/8/2020 10:31 AM, Laurent Hardy wrote: Hi all, On 1/8/20 10:55 AM, David Marchand wrote: > On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit > wrot

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-05-08 Thread Ferruh Yigit
On 1/8/2020 2:07 PM, Thomas Monjalon wrote: > 08/01/2020 14:58, Laurent Hardy: >> About the 'is_supported()' versions of APIs, in the current patch I >> factorize >> the check on dev ops on and off availability in a same function named >> "led_ctrl_capable" but I can rename it if required. >> >> J

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
On 1/8/20 3:07 PM, Thomas Monjalon wrote: 08/01/2020 14:58, Laurent Hardy: About the 'is_supported()' versions of APIs, in the current patch I factorize the check on dev ops on and off availability in a same function named "led_ctrl_capable" but I can rename it if required. Just in this speci

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
On 1/8/20 3:08 PM, Ferruh Yigit wrote: On 1/8/2020 12:27 PM, Olivier Matz wrote: On Wed, Jan 08, 2020 at 12:12:11PM +, Ferruh Yigit wrote: On 1/8/2020 9:42 AM, Olivier Matz wrote: On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: H

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Andrew Rybchenko
On 1/8/20 5:27 PM, Thomas Monjalon wrote: > 08/01/2020 15:15, Andrew Rybchenko: >> On 1/8/20 4:52 PM, Ferruh Yigit wrote: >>> On 1/8/2020 1:25 PM, Thomas Monjalon wrote: 08/01/2020 14:20, Ferruh Yigit: > On 1/8/2020 1:06 PM, Thomas Monjalon wrote: >> 08/01/2020 13:59, Ferruh Yigit: >>>

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 15:15, Andrew Rybchenko: > On 1/8/20 4:52 PM, Ferruh Yigit wrote: > > On 1/8/2020 1:25 PM, Thomas Monjalon wrote: > >> 08/01/2020 14:20, Ferruh Yigit: > >>> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: > 08/01/2020 13:59, Ferruh Yigit: > > But for dev_ops, instead of having anoth

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Andrew Rybchenko
On 1/8/20 4:52 PM, Ferruh Yigit wrote: > On 1/8/2020 1:25 PM, Thomas Monjalon wrote: >> 08/01/2020 14:20, Ferruh Yigit: >>> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: > But for dev_ops, instead of having another capabilities indicator, which > requires

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 12:27 PM, Olivier Matz wrote: > On Wed, Jan 08, 2020 at 12:12:11PM +, Ferruh Yigit wrote: >> On 1/8/2020 9:42 AM, Olivier Matz wrote: >>> On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: > Hello Laurent, > > Bo

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 14:58, Laurent Hardy: > About the 'is_supported()' versions of APIs, in the current patch I > factorize > the check on dev ops on and off availability in a same function named > "led_ctrl_capable" but I can rename it if required. > > Just in this specific case I don't dissociate on and

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:52 PM, Ferruh Yigit wrote: > On 1/8/2020 1:25 PM, Thomas Monjalon wrote: >> 08/01/2020 14:20, Ferruh Yigit: >>> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: > But for dev_ops, instead of having another capabilities indicator, which > require

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
On 1/8/20 2:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: On 1/8/2020 10:31 AM, Laurent Hardy wrote: Hi all, On 1/8/20 10:55 AM, David Marchand wrote: On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: Hello Laurent, Bonne anné

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:34 PM, Thomas Monjalon wrote: > 08/01/2020 14:25, Thomas Monjalon: >> 08/01/2020 14:20, Ferruh Yigit: >>> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: > But for dev_ops, instead of having another capabilities indicator, which > requires PMDs

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:25 PM, Thomas Monjalon wrote: > 08/01/2020 14:20, Ferruh Yigit: >> On 1/8/2020 1:06 PM, Thomas Monjalon wrote: >>> 08/01/2020 13:59, Ferruh Yigit: But for dev_ops, instead of having another capabilities indicator, which requires PMDs to keep this synchronized, I think it is

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 14:25, Thomas Monjalon: > 08/01/2020 14:20, Ferruh Yigit: > > On 1/8/2020 1:06 PM, Thomas Monjalon wrote: > > > 08/01/2020 13:59, Ferruh Yigit: > > >> But for dev_ops, instead of having another capabilities indicator, which > > >> requires PMDs to keep this synchronized, I think it is be

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 14:20, Ferruh Yigit: > On 1/8/2020 1:06 PM, Thomas Monjalon wrote: > > 08/01/2020 13:59, Ferruh Yigit: > >> But for dev_ops, instead of having another capabilities indicator, which > >> requires PMDs to keep this synchronized, I think it is better if we can > >> self > >> contain this i

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:06 PM, Thomas Monjalon wrote: > 08/01/2020 13:59, Ferruh Yigit: >> On 1/8/2020 10:31 AM, Laurent Hardy wrote: >>> Hi all, >>> >>> On 1/8/20 10:55 AM, David Marchand wrote: On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: > On 1/8/2020 8:56 AM, David Marchand wrote:

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 1:00 PM, David Marchand wrote: > On Wed, Jan 8, 2020 at 1:30 PM Ferruh Yigit wrote: >> On 1/8/2020 9:55 AM, David Marchand wrote: >>> On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: Why it is an ABI break, dev_ops should be between library and drivers, so it should

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Thomas Monjalon
08/01/2020 13:59, Ferruh Yigit: > On 1/8/2020 10:31 AM, Laurent Hardy wrote: > > Hi all, > > > > On 1/8/20 10:55 AM, David Marchand wrote: > >> On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit > >> wrote: > >>> On 1/8/2020 8:56 AM, David Marchand wrote: > Hello Laurent, > > Bonne anné

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread David Marchand
On Wed, Jan 8, 2020 at 1:30 PM Ferruh Yigit wrote: > On 1/8/2020 9:55 AM, David Marchand wrote: > > On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: > >> Why it is an ABI break, dev_ops should be between library and drivers, so > >> it > >> should be out of the ABI concern, isn't it. > > > >

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 10:31 AM, Laurent Hardy wrote: > Hi all, > > On 1/8/20 10:55 AM, David Marchand wrote: >> On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: >>> On 1/8/2020 8:56 AM, David Marchand wrote: Hello Laurent, Bonne année. Cc: maintainers. On Tue, Jan 7, 2

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 9:55 AM, David Marchand wrote: > On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: >> >> On 1/8/2020 8:56 AM, David Marchand wrote: >>> Hello Laurent, >>> >>> Bonne année. >>> >>> Cc: maintainers. >>> >>> On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy >>> wrote: In current

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Olivier Matz
On Wed, Jan 08, 2020 at 12:12:11PM +, Ferruh Yigit wrote: > On 1/8/2020 9:42 AM, Olivier Matz wrote: > > On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: > >> On 1/8/2020 8:56 AM, David Marchand wrote: > >>> Hello Laurent, > >>> > >>> Bonne année. > >>> > >>> Cc: maintainers. > >>>

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 9:42 AM, Olivier Matz wrote: > On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: >> On 1/8/2020 8:56 AM, David Marchand wrote: >>> Hello Laurent, >>> >>> Bonne année. >>> >>> Cc: maintainers. >>> >>> On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy >>> wrote: In curr

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
Hi all, On 1/8/20 10:55 AM, David Marchand wrote: On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: Hello Laurent, Bonne année. Cc: maintainers. On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy wrote: In current led control API we have no way to k

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread David Marchand
On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: > > On 1/8/2020 8:56 AM, David Marchand wrote: > > Hello Laurent, > > > > Bonne année. > > > > Cc: maintainers. > > > > On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy > > wrote: > >> > >> In current led control API we have no way to know if a dev

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Olivier Matz
On Wed, Jan 08, 2020 at 09:09:29AM +, Ferruh Yigit wrote: > On 1/8/2020 8:56 AM, David Marchand wrote: > > Hello Laurent, > > > > Bonne année. > > > > Cc: maintainers. > > > > On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy > > wrote: > >> > >> In current led control API we have no way to kno

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Ferruh Yigit
On 1/8/2020 8:56 AM, David Marchand wrote: > Hello Laurent, > > Bonne année. > > Cc: maintainers. > > On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy wrote: >> >> In current led control API we have no way to know if a device is able >> to handle on/off requests coming from the application. >> Know

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread David Marchand
Hello Laurent, Bonne année. Cc: maintainers. On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy wrote: > > In current led control API we have no way to know if a device is able > to handle on/off requests coming from the application. > Knowing if the device is led control capable could be useful to a

[dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-07 Thread Laurent Hardy
In current led control API we have no way to know if a device is able to handle on/off requests coming from the application. Knowing if the device is led control capable could be useful to avoid exchanges between application and kernel. Using the on/off requests to flag if the device is led control