[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-11-17 Thread Neil Horman
On Mon, Nov 03, 2014 at 08:41:53AM +0100, Thomas Monjalon wrote: > 2014-10-09 07:29, Neil Horman: > > On Thu, Oct 09, 2014 at 05:20:31AM +, Wu, Jingjing wrote: > > > Hi, Neil > > > > > > To have rte_ip.h include netinet/in.h directly is also a choice. > > > > > > But netinet/in.h contains a l

[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-11-03 Thread Thomas Monjalon
2014-10-09 07:29, Neil Horman: > On Thu, Oct 09, 2014 at 05:20:31AM +, Wu, Jingjing wrote: > > Hi, Neil > > > > To have rte_ip.h include netinet/in.h directly is also a choice. > > > > But netinet/in.h contains a lot of extra stuff, and these may be useless > > some DPDK applications, such a

[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-10-09 Thread Neil Horman
h is neither relevant or true (as you can't really say for certain what an application will need). Neil > -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Tuesday, September 30, 2014 9:10 PM > To: Wu, Jingjing > Cc: dev at dpdk.org >

[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-10-09 Thread Wu, Jingjing
: Neil Horman [mailto:nhor...@tuxdriver.com] Sent: Tuesday, September 30, 2014 9:10 PM To: Wu, Jingjing Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict On Tue, Sep 30, 2014 at 10:49:08AM +0800, Jingjing Wu wrote: > Macros such as IPPROTO_

[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-10-09 Thread Wu, Jingjing
plify way for the IP protocol layer. > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, September 30, 2014 1:08 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to

[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-10-08 Thread Matthew Hall
yer. > >-Original Message- >From: Neil Horman [mailto:nhorman at tuxdriver.com] >Sent: Tuesday, September 30, 2014 9:10 PM >To: Wu, Jingjing >Cc: dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid >macro conflict > >On Tue, Sep 30

[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-09-30 Thread Jingjing Wu
Macros such as IPPROTO_TCP, IPPROTO_UDP are already defined in . If user's application includes and rte_ip.h at the same time, there will be conflict error. This patch uses the way "#ifndef #endif" to avoid the conflict. Signed-off-by: Jingjing Wu --- lib/librte_net/rte_ip.h | 5 + 1 file

[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-09-30 Thread Neil Horman
On Tue, Sep 30, 2014 at 10:49:08AM +0800, Jingjing Wu wrote: > Macros such as IPPROTO_TCP, IPPROTO_UDP are already defined in . > If user's application includes and rte_ip.h at the same time, > there will be conflict error. > > This patch uses the way "#ifndef #endif" to avoid the conflict. > >

[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

2014-09-30 Thread Thomas Monjalon
Hi Jingjing, 2014-09-30 10:49, Jingjing Wu: > Macros such as IPPROTO_TCP, IPPROTO_UDP are already defined in . > If user's application includes and rte_ip.h at the same time, > there will be conflict error. > > This patch uses the way "#ifndef #endif" to avoid the conflict. I still think it is