Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-10 Thread Andrzej Ostruszka
On 3/9/20 8:13 PM, Stephen Hemminger wrote: > On Mon, 9 Mar 2020 18:02:21 + > "Medvedkin, Vladimir" wrote: > >> On 09/03/2020 15:52, Stephen Hemminger wrote: >>> On Mon, 9 Mar 2020 13:38:53 + >>> "Medvedkin, Vladimir" wrote: >>> Hi Andrze, Adding const qualifier for bulk

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2020 18:02:21 + "Medvedkin, Vladimir" wrote: > On 09/03/2020 15:52, Stephen Hemminger wrote: > > On Mon, 9 Mar 2020 13:38:53 + > > "Medvedkin, Vladimir" wrote: > > > >> Hi Andrze, > >> > >> Adding const qualifier for bulk lookup leads to compilation problems > >> (see htt

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2020 18:02:21 + "Medvedkin, Vladimir" wrote: > On 09/03/2020 15:52, Stephen Hemminger wrote: > > On Mon, 9 Mar 2020 13:38:53 + > > "Medvedkin, Vladimir" wrote: > > > >> Hi Andrze, > >> > >> Adding const qualifier for bulk lookup leads to compilation problems > >> (see htt

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Medvedkin, Vladimir
On 09/03/2020 15:52, Stephen Hemminger wrote: On Mon, 9 Mar 2020 13:38:53 + "Medvedkin, Vladimir" wrote: Hi Andrze, Adding const qualifier for bulk lookup leads to compilation problems (see http://c-faq.com/ansi/constmismatch.html) Also I don't think it would be good for usability to ma

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2020 13:38:53 + "Medvedkin, Vladimir" wrote: > Hi Andrze, > > Adding const qualifier for bulk lookup leads to compilation problems > (see http://c-faq.com/ansi/constmismatch.html) > Also I don't think it would be good for usability to make users > explicitly cast to (const ui

Re: [dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-09 Thread Medvedkin, Vladimir
Hi Andrze, Adding const qualifier for bulk lookup leads to compilation problems (see http://c-faq.com/ansi/constmismatch.html) Also I don't think it would be good for usability to make users explicitly cast to (const uint8_t **) when passing 'ips' argument. I'd suggest leaving lookup_bulk as i

[dpdk-dev] [PATCH] lpm6: make IPv6 addresses immutable

2020-03-03 Thread Andrzej Ostruszka
None of the public functions modify IPv6 address passed so their parameters are made const. Previously only lookup and add were updated to have addresses passed as const so I'm adding this fixline. Fixes: d82927d2f81d ("lpm6: make IPv6 address immutable") Cc: step...@networkplumber.org Signed-of