Re: [dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-26 Thread Wang, Yipeng1
Sure. Thanks Anatoly, Please go ahead and submit V2. Thanks Yipeng >-Original Message- >From: Burakov, Anatoly >Sent: Saturday, December 23, 2017 3:55 AM >To: Wang, Yipeng1 ; dev@dpdk.org >Cc: Gobriel, Sameh >Subject: Re: [PATCH] member: fix memory leak on error > >On 22-Dec-17 6:33 PM

Re: [dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-23 Thread Burakov, Anatoly
On 22-Dec-17 6:33 PM, Wang, Yipeng1 wrote: -Original Message- From: Burakov, Anatoly Yep, i can see that now. Didn't think to look inside rte_member_free() :/ However, you're creating a race condition there - you're unlocking a tailq, and then locking (and unlocking) it again inside rte_m

Re: [dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-22 Thread Wang, Yipeng1
>-Original Message- >From: Burakov, Anatoly >Yep, i can see that now. Didn't think to look inside rte_member_free() >:/ However, you're creating a race condition there - you're unlocking a >tailq, and then locking (and unlocking) it again inside >rte_member_free() - it probably needs _threa

Re: [dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-22 Thread Burakov, Anatoly
On 22-Dec-17 12:01 AM, Wang, Yipeng1 wrote: Thank you Anatoly for finding this issue. In the code I tried to reuse the rte_member_free function to free memory but it may not be executed through. Because of this, I may not properly release setsum struct neither. I will post a fix for both soon.

Re: [dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-21 Thread Wang, Yipeng1
Btw, Pablo, since I remember I refer to the EFD library on my membership implementation, does EFD have similar memory leakage issue that not releasing te when failure? Thanks >-Original Message- >From: Wang, Yipeng1 >Sent: Thursday, December 21, 2017 4:01 PM >To: Burakov, Anatoly ; dev@

Re: [dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-21 Thread Wang, Yipeng1
Thank you Anatoly for finding this issue. In the code I tried to reuse the rte_member_free function to free memory but it may not be executed through. Because of this, I may not properly release setsum struct neither. I will post a fix for both soon. Thanks >-Original Message- >From:

[dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-21 Thread Anatoly Burakov
rte_member may have allocated a tailq entry before failure, so free it. Fixes: 857ed6c68cf2 ("member: implement main API") Cc: yipeng1.w...@intel.com Signed-off-by: Anatoly Burakov --- lib/librte_member/rte_member.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_member/rte_member