Re: [dpdk-dev] [PATCH] mk: use misleading indentation warning when available

2018-12-19 Thread Burakov, Anatoly
On 19-Dec-18 9:24 AM, Gaëtan Rivet wrote: On Tue, Dec 18, 2018 at 02:50:30PM +, Ferruh Yigit wrote: On 12/18/2018 10:26 AM, Gaetan Rivet wrote: -Wmisleading-indentation was introduced in GCC 6.0. It seems '-Wmisleading-indentation' is part of -Wall, which we already set by default. If so

Re: [dpdk-dev] [PATCH] mk: use misleading indentation warning when available

2018-12-19 Thread Gaëtan Rivet
On Tue, Dec 18, 2018 at 02:50:30PM +, Ferruh Yigit wrote: > On 12/18/2018 10:26 AM, Gaetan Rivet wrote: > > -Wmisleading-indentation was introduced in GCC 6.0. > > It seems '-Wmisleading-indentation' is part of -Wall, which we already set by > default. If so no need to explicitly add it. > >

Re: [dpdk-dev] [PATCH] mk: use misleading indentation warning when available

2018-12-18 Thread Ferruh Yigit
On 12/18/2018 10:26 AM, Gaetan Rivet wrote: > -Wmisleading-indentation was introduced in GCC 6.0. It seems '-Wmisleading-indentation' is part of -Wall, which we already set by default. If so no need to explicitly add it. The link I found: https://www.gnu.org/software/gcc/gcc-6/porting_to.html co

[dpdk-dev] [PATCH] mk: use misleading indentation warning when available

2018-12-18 Thread Gaetan Rivet
-Wmisleading-indentation was introduced in GCC 6.0. Use it at least when available. This should catch most common error of the types (due to the codebase being properly tabbed), but will still miss patterns such as if (!condition) // commented_fn_call(); do_stuff(); Signed-off-by