Re: [dpdk-dev] [PATCH] net/af_packet: fix ignoring full ring on tx

2021-09-20 Thread Ferruh Yigit
On 9/6/2021 11:23 AM, Tudor Cornea wrote: > Hi Ferruh, > > Would you mind separate timestamp status fix to its own patch? I think >> better to >> fix 'ignoring full Tx ring' first, to not make it dependent to timestamp >> patch. > > > Agreed. There are two issues solved by this patch. We will br

Re: [dpdk-dev] [PATCH] net/af_packet: fix ignoring full ring on tx

2021-09-06 Thread Tudor Cornea
Hi Ferruh, Would you mind separate timestamp status fix to its own patch? I think > better to > fix 'ignoring full Tx ring' first, to not make it dependent to timestamp > patch. Agreed. There are two issues solved by this patch. We will break it in two different patches. I can see 'TP_STATUS_TS

Re: [dpdk-dev] [PATCH] net/af_packet: fix ignoring full ring on tx

2021-09-01 Thread Ferruh Yigit
On 8/20/2021 2:39 PM, Tudor Cornea wrote: > The poll call can return POLLERR which is ignored, or it can return > POLLOUT, even if there are no free frames in the mmap-ed area. > > We can account for both of these cases by re-checking if the next > frame is empty before writing into it. > > We al

[dpdk-dev] [PATCH] net/af_packet: fix ignoring full ring on tx

2021-08-20 Thread Tudor Cornea
The poll call can return POLLERR which is ignored, or it can return POLLOUT, even if there are no free frames in the mmap-ed area. We can account for both of these cases by re-checking if the next frame is empty before writing into it. We also now eliminate the timestamp status from the frame sta